Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temp: enable upgrades on all chains #4677

Closed
wants to merge 12 commits into from
Closed

Temp: enable upgrades on all chains #4677

wants to merge 12 commits into from

Conversation

katspaugh
Copy link
Member

Test branch, don't merge.

Copy link

github-actions bot commented Dec 17, 2024

Copy link

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1017.35 KB (🟡 +906 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/settings/setup 30.69 KB (🟢 -119 B) 1.02 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

Coverage report

Caution

Test run failed

St.
Category Percentage Covered / Total
🟡 Statements
73.73% (-0.12% 🔻)
14416/19553
🔴 Branches
51.15% (-0.24% 🔻)
3435/6715
🔴 Functions
56.5% (-0.27% 🔻)
2034/3600
🟡 Lines
75.28% (-0.09% 🔻)
13081/17376
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / safe-migrations.ts
96.43% 87.5% 100% 96.23%
🟢
... / index.tsx
80% 100% 0% 100%
🟡
... / index.tsx
61.54% 0% 0% 66.67%
🔴
... / SubAccountItem.tsx
53.19% 0% 0% 56.82%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🔴
... / local.ts
70% (-10% 🔻)
50%
25% (-25% 🔻)
57.14% (-14.29% 🔻)
🟢
... / index.ts
97.22% (-2.78% 🔻)
71.43% (-28.57% 🔻)
100%
96.97% (-3.03% 🔻)
🟡
... / transaction-guards.ts
70.11% (-2.58% 🔻)
42.45% (+1.4% 🔼)
69.01% (-2% 🔻)
70.68% (-2.8% 🔻)
🟢 src/utils/chains.ts 93.1%
90% (-1.67% 🔻)
100% 100%
🟢
... / safePass.ts
90.91%
50% (-25% 🔻)
50% 88.89%
🔴
... / index.tsx
50% (-5% 🔻)
0% 0% 55.56%
🟢
... / TagManager.ts
91.43% (-5.71% 🔻)
66.67% (-33.33% 🔻)
90%
90.63% (-6.25% 🔻)
🟡
... / transactions.ts
70% (-7.62% 🔻)
39.02% (-15.98% 🔻)
45% (-5% 🔻)
71.76% (-7.6% 🔻)
🟢
... / utils.ts
90.91% (+0.24% 🔼)
71.88% (-8.13% 🔻)
90%
95.08% (+0.17% 🔼)
🟢
... / index.tsx
97.67%
96.43% (-0.24% 🔻)
100% 100%
🟢
... / index.tsx
91.18% (-5.79% 🔻)
82.86% (-10% 🔻)
100% 100%
🟢
... / index.tsx
100%
81.82% (-1.52% 🔻)
100% 100%
🟢
... / index.tsx
98.31% (-1.69% 🔻)
85% (-5% 🔻)
100%
98.15% (-1.85% 🔻)
🟢
... / useSafeTokenAllocation.ts
94.38%
78.26% (-4.35% 🔻)
100% 93.83%
🟡
... / index.tsx
76.47% (-1.65% 🔻)
10.53% (-0.58% 🔻)
100%
75.76% (-1.66% 🔻)
🟢
... / index.tsx
92.86% (-3.14% 🔻)
71.43% (-0.79% 🔻)
100% 100%
🟢
... / index.tsx
95% (-0.45% 🔻)
85.71% 100% 100%
🟡
... / useAllSafesGrouped.ts
55.17% (-33.4% 🔻)
0% (-66.67% 🔻)
27.27% (-57.34% 🔻)
65.22% (-34.78% 🔻)
🟢
... / safeUpdateParams.ts
92% (-3.24% 🔻)
0% 100%
91.67% (-3.33% 🔻)
🟡 src/pages/_app.tsx 69.23%
28.57% (-14.29% 🔻)
0% 68%
🟢
... / index.tsx
85.71% (-4.29% 🔻)
100% 50% 100%

Test suite run failed

Failed tests: 2/1703. Failed suites: 2/230.
  ● SafeTokenWidget › Should render a link to the governance app

    expect(element).toContainHTML()
    Expected:
      href="/apps/open?safe=0x0000000000000000000000000000000000000001&appUrl=https%3A%2F%2Fsafe-dao-governance.dev.5afe.dev
    Received:
      <body><div><div class="container MuiBox-root css-0"><span aria-label="Go to Safe{DAO} Governance" class="" data-mui-internal-clone-element="true"><span data-track="overview: Open Safe Governance App from widget"><a aria-describedby="safe-token-widget" class="MuiButtonBase-root tokenButton css-1i1o7bi-MuiButtonBase-root" href="/apps/open?safe=0x0000000000000000000000000000000000000001&appUrl=https%3A%2F%2Fcommunity.safe.global" tabindex="0"><mock-icon height="24" width="24" /><div class="MuiTypography-root MuiTypography-body2 allocationBadge css-22wu2-MuiTypography-root"><span class="MuiBadge-root css-63ezxx-MuiBadge-root">0<span class="MuiBadge-badge MuiBadge-dot MuiBadge-invisible MuiBadge-anchorOriginBottomRight MuiBadge-anchorOriginBottomRightRectangular MuiBadge-overlapRectangular MuiBadge-colorSuccess css-3py7df-MuiBadge-badge" /></span></div><div aria-orientation="vertical" class="MuiDivider-root MuiDivider-fullWidth MuiDivider-vertical css-19qy22f-MuiDivider-root" role="separator" /><mock-icon aria-hidden="" class="MuiSvgIcon-root MuiSvgIcon-fontSizeMedium css-1dhtbeh-MuiSvgIcon-root" focusable="false" height="24" width="24" /><div class="MuiTypography-root MuiTypography-body2 allocationBadge css-vt8sx8-MuiTypography-root">0</div></a></span></span></div></div></body>

    Ignored nodes: comments, script, style
    <html
      data-theme="light"
    >
      <head />
      <body>
        <div>
          <div
            class="container MuiBox-root css-0"
          >
            <span
              aria-label="Go to Safe{DAO} Governance"
              class=""
              data-mui-internal-clone-element="true"
            >
              <span
                data-track="overview: Open Safe Governance App from widget"
              >
                <a
                  aria-describedby="safe-token-widget"
                  class="MuiButtonBase-root tokenButton css-1i1o7bi-MuiButtonBase-root"
                  href="/apps/open?safe=0x0000000000000000000000000000000000000001&appUrl=https%3A%2F%2Fcommunity.safe.global"
                  tabindex="0"
                >
                  <mock-icon
                    height="24"
                    width="24"
                  />
                  <div
                    class="MuiTypography-root MuiTypography-body2 allocationBadge css-22wu2-MuiTypography-root"
                  >
                    <span
                      class="MuiBadge-root css-63ezxx-MuiBadge-root"
                    >
                      0
                      <span
                        class="MuiBadge-badge MuiBadge-dot MuiBadge-invisible MuiBadge-anchorOriginBottomRight MuiBadge-anchorOriginBottomRightRectangular MuiBadge-overlapRectangular MuiBadge-colorSuccess css-3py7df-MuiBadge-badge"
                      />
                    </span>
                  </div>
                  <div
                    aria-orientation="vertical"
                    class="MuiDivider-root MuiDivider-fullWidth MuiDivider-vertical css-19qy22f-MuiDivider-root"
                    role="separator"
                  />
                  <mock-icon
                    aria-hidden=""
                    class="MuiSvgIcon-root MuiSvgIcon-fontSizeMedium css-1dhtbeh-MuiSvgIcon-root"
                    focusable="false"
                    height="24"
                    width="24"
                  />
                  <div
                    class="MuiTypography-root MuiTypography-body2 allocationBadge css-vt8sx8-MuiTypography-root"
                  >
                    0
                  </div>
                </a>
              </span>
            </span>
          </div>
        </div>
      </body>
    </html>

      66 |     const result = render(<SafeTokenWidget />)
      67 |     await waitFor(() => {
    > 68 |       expect(result.baseElement).toContainHTML(
         |                                  ^
      69 |         `href="${AppRoutes.apps.open}?safe=${fakeSafeAddress}&appUrl=${encodeURIComponent(
      70 |           'https://safe-dao-governance.dev.5afe.dev',
      71 |         )}`,

      at toContainHTML (src/components/common/SafeTokenWidget/__tests__/SafeTokenWidget.test.tsx:68:34)
      at runWithExpensiveErrorDiagnosticsDisabled (node_modules/@testing-library/dom/dist/config.js:47:12)
      at checkCallback (node_modules/@testing-library/dom/dist/wait-for.js:124:77)
      at checkRealTimersCallback (node_modules/@testing-library/dom/dist/wait-for.js:118:16)
      at Timeout.task [as _onTimeout] (node_modules/jsdom/lib/jsdom/browser/Window.js:520:19)


  ● useChainId hook › should return the default chainId if no query params

    expect(received).toBe(expected) // Object.is equality

    Expected: "11155111"
    Received: "1"

      57 |   it('should return the default chainId if no query params', () => {
      58 |     const { result } = renderHook(() => useChainId())
    > 59 |     expect(result.current).toBe('11155111')
         |                            ^
      60 |   })
      61 |
      62 |   it('should return the chainId based on the chain query', () => {

      at Object.toBe (src/hooks/__tests__/useChainId.test.ts:59:28)

Report generated by 🧪jest coverage report action from 13e8fa7

@katspaugh katspaugh closed this Dec 18, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant