-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests: Cypress tests imrpovements #2816
Changes from all commits
fd0e97b
110a944
9aaaec2
b93e392
cdaae40
5a43ee6
3302aa0
5147e2f
ef407c5
ad453ea
23e6768
13104c6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
name: Regression on demand tests | ||
|
||
on: | ||
workflow_dispatch: | ||
|
||
concurrency: | ||
group: ${{ github.workflow }}-${{ github.ref }} | ||
cancel-in-progress: true | ||
|
||
jobs: | ||
e2e: | ||
runs-on: ubuntu-20.04 | ||
name: Cypress Regression on demand tests | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
containers: [1, 2, 3, 4, 5] | ||
steps: | ||
- uses: actions/checkout@v3 | ||
|
||
- uses: ./.github/workflows/yarn | ||
|
||
- name: Install Cypress | ||
run: | | ||
./node_modules/.bin/cypress install | ||
|
||
- uses: ./.github/workflows/build | ||
with: | ||
secrets: ${{ toJSON(secrets) }} | ||
e2e_mnemonic: ${{ secrets.NEXT_PUBLIC_CYPRESS_MNEMONIC }} | ||
|
||
- name: Serve | ||
run: yarn serve & | ||
|
||
- uses: cypress-io/github-action@v4 | ||
with: | ||
parallel: true | ||
spec: cypress/e2e/**/*.cy.js | ||
browser: chrome | ||
record: true | ||
config: baseUrl=http://localhost:8080 | ||
group: 'Regression on demand tests' | ||
env: | ||
CYPRESS_RECORD_KEY: ${{ secrets.CYPRESS_RECORD_KEY }} | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
name: Regression tests | ||
|
||
on: | ||
pull_request: | ||
branches: | ||
- 'release**' | ||
- 'release/**' | ||
|
||
concurrency: | ||
group: ${{ github.workflow }}-${{ github.ref }} | ||
cancel-in-progress: true | ||
|
||
jobs: | ||
e2e: | ||
runs-on: ubuntu-20.04 | ||
name: Cypress Regression tests | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
containers: [1, 2, 3] | ||
steps: | ||
- uses: actions/checkout@v3 | ||
|
||
- uses: ./.github/workflows/yarn | ||
|
||
- name: Install Cypress | ||
run: | | ||
./node_modules/.bin/cypress install | ||
|
||
- uses: ./.github/workflows/build | ||
with: | ||
secrets: ${{ toJSON(secrets) }} | ||
e2e_mnemonic: ${{ secrets.NEXT_PUBLIC_CYPRESS_MNEMONIC }} | ||
|
||
- name: Serve | ||
run: yarn serve & | ||
|
||
- uses: cypress-io/github-action@v4 | ||
with: | ||
parallel: true | ||
spec: cypress/e2e/**/*.cy.js | ||
browser: chrome | ||
record: true | ||
config: baseUrl=http://localhost:8080 | ||
group: 'Regression tests' | ||
env: | ||
CYPRESS_RECORD_KEY: ${{ secrets.CYPRESS_RECORD_KEY }} | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,7 +15,7 @@ jobs: | |
strategy: | ||
fail-fast: false | ||
matrix: | ||
containers: [1, 2, 3] | ||
containers: [1, 2] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Another arbitrary change, what's the reasoning here? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @katspaugh there are not many tests in safe apps, that's why reducing number of machines makes sense. As you said, there's more overhead starting the machine than running the tests themselves. |
||
steps: | ||
- uses: actions/checkout@v3 | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
name: e2e | ||
name: Smoke tests | ||
|
||
on: | ||
pull_request: | ||
|
@@ -14,7 +14,7 @@ jobs: | |
strategy: | ||
fail-fast: false | ||
matrix: | ||
containers: [1, 2, 3] | ||
containers: [1, 2, 3, 4, 5] | ||
steps: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why this change? From what I see each container still runs for about 7 minutes. There's more overhead starting the machine than running the tests themselves. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @katspaugh we will be adding more tests to the suite. Adding more machines will reduce time spent on tests going forward. |
||
- uses: actions/checkout@v3 | ||
|
||
|
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tested it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@katspaugh no, from what I understand it must be merged to dev first so the workflow is available