Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update comments in SignatureVerifierMuxer to reflect correct byte ranges for encodeData and payload lengths #873

Merged
merged 3 commits into from
Jan 9, 2025
Merged

Update comments in SignatureVerifierMuxer to reflect correct byte ranges for encodeData and payload lengths #873

merged 3 commits into from
Jan 9, 2025

Conversation

mmv08
Copy link
Member

@mmv08 mmv08 commented Dec 19, 2024

This pull request includes modifying the SignatureVerifierMuxer contract to correct the byte offsets for encoding and payload data.

Changes to byte offsets:

@mmv08 mmv08 requested review from a team, nlordell, akshay-ap, remedcu and rmeissner and removed request for a team December 19, 2024 10:53
remedcu
remedcu approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@remedcu remedcu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uber nit: Should we use to instead of -, as we are using the arithmetic + in this context?

@mmv08
Copy link
Member Author

mmv08 commented Jan 9, 2025

uber nit: Should we use to instead of -, as we are using the arithmetic + in this context?

good idea, thanks

@mmv08 mmv08 merged commit ff36adb into main Jan 9, 2025
25 checks passed
@mmv08 mmv08 deleted the fix/incorrect-length-comment-svm branch January 9, 2025 15:03
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jakeshelly jakeshelly jakeshelly approved these changes

@sara554-beep sara554-beep sara554-beep approved these changes

@remedcu remedcu remedcu approved these changes

@nlordell nlordell Awaiting requested review from nlordell nlordell was automatically assigned from safe-global/safe-protocol

@akshay-ap akshay-ap Awaiting requested review from akshay-ap akshay-ap was automatically assigned from safe-global/safe-protocol

@rmeissner rmeissner Awaiting requested review from rmeissner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mmv08 @remedcu @sara554-beep @jakeshelly