fix: use consts for thresholds

safe-global · Jul 8, 2024 · 586e4fe · 586e4fe
1 parent 9b07ddb
commit 586e4fe
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 12 deletions.
diff --git a/src/components/DataRoom/CryptoPunks/utils.ts b/src/components/DataRoom/CryptoPunks/utils.ts
diff --git a/src/components/DataRoom/TransactionsOnChain/useCounterScroll.ts b/src/components/DataRoom/TransactionsOnChain/useCounterScroll.ts
@@ -1,17 +1,22 @@
 import type { MotionValue } from 'framer-motion'
 import { useEffect, useState } from 'react'
 
+// Thresholds for scroll progress
+const SCROLL_THRESHOLD_UPPER = 0.21
+const SCROLL_THRESHOLD_LOWER = 0.2
+const INITIAL_VALUE = 0
+
 // Custom hook for managing counter based on scroll
 export function useCounterScroll(scrollYProgress: MotionValue<number>, percentage: number): number {
   const [value, setValue] = useState(0)
 
   useEffect(() => {
     const checkScrollProgress = () => {
       const latest = scrollYProgress.get()
-      if (latest >= 0.21) {
+      if (latest >= SCROLL_THRESHOLD_UPPER) {
         setValue(percentage)
-      } else if (latest <= 0.2) {
-        setValue(0)
+      } else if (latest <= SCROLL_THRESHOLD_LOWER) {
+        setValue(INITIAL_VALUE)
       }
     }