Various fixes

safe-global · Oct 21, 2024 · a81b921 · a81b921
1 parent d086426
commit a81b921
Show file tree

Hide file tree

Showing 7 changed files with 73 additions and 17 deletions.
diff --git a/pages/reference-smart-account/owners/_meta.json b/pages/reference-smart-account/owners/_meta.json
@@ -1,8 +1,8 @@
 {
   "addOwnerWithThreshold": "addOwnerWithThreshold",
   "changeThreshold": "changeThreshold",
-  "getThreshold": "getThreshold",
   "getOwners": "getOwners",
+  "getThreshold": "getThreshold",
   "isOwner": "isOwner",
   "removeOwner": "removeOwner",
   "swapOwner": "swapOwner"

diff --git a/pages/reference-smart-account/owners/addOwnerWithThreshold.mdx b/pages/reference-smart-account/owners/addOwnerWithThreshold.mdx
@@ -20,7 +20,7 @@ This can only be done via a Safe transaction.
     }
 
     contract Example {
-        function example() … {
+        function example() ... {
             (ISafe safe).addOwnerWithThreshold(
                 "0x...",
                 1

diff --git a/pages/reference-smart-account/owners/changeThreshold.mdx b/pages/reference-smart-account/owners/changeThreshold.mdx
@@ -18,6 +18,14 @@ This can only be done via a Safe transaction.
     interface ISafe {
         function changeThreshold(uint256 _threshold) external
     }
+
+    contract Example {
+        function example() ... {
+            (ISafe safe).changeThreshold(
+                1
+            )
+        }
+    }
 ```
 </Tabs.Tab>
 </Tabs>

diff --git a/pages/reference-smart-account/owners/getThreshold.mdx b/pages/reference-smart-account/owners/getThreshold.mdx
@@ -2,13 +2,6 @@ import { Tabs } from "nextra/components"
 
 # `getThreshold`
 
-## Overview
-
-```solidity
-function getThreshold() external view returns (uint256)
-
-```
-
 Returns the number of required confirmations for a Safe transaction aka the threshold.
 
 ## Usage
@@ -17,8 +10,12 @@ Returns the number of required confirmations for a Safe transaction aka the thre
 <Tabs items={['example.sol']}>
   <Tabs.Tab>
     ```solidity
+    interface ISafe {
+        function getThreshold() external view returns (uint256)
+    }
+
     contract Example {
-        function example() … {
+        function example() ... {
             (uint256 threshold) = (ISafe safe).getThreshold(); // 1
         }
     }

diff --git a/pages/reference-smart-account/owners/isOwner.mdx b/pages/reference-smart-account/owners/isOwner.mdx
@@ -11,6 +11,10 @@ Returns if `owner` is an owner of the Safe.
 <Tabs items={['example.sol']}>
   <Tabs.Tab>
     ```solidity
+    interface ISafe {
+        function isOwner(address owner) external view returns (bool)
+    }
+
     contract Example {
         function example() … {
             (bool isOwner) = (ISafe safe).isOwner("0x..."); // true

diff --git a/pages/reference-smart-account/owners/removeOwner.mdx b/pages/reference-smart-account/owners/removeOwner.mdx
@@ -16,7 +16,7 @@ This can only be done via a Safe transaction.
 
 <Tabs items={['example.sol']}>
   <Tabs.Tab>
-```solidity
+    ```solidity
     interface ISafe {
         function removeOwner(address prevOwner, address owner, uint256 _threshold) external
     }
@@ -30,7 +30,7 @@ This can only be done via a Safe transaction.
             )
         }
     }
-```
+    ```
 </Tabs.Tab>
 </Tabs>
 
@@ -43,18 +43,42 @@ This can only be done via a Safe transaction.
 
 Owner that pointed to the owner to be removed in the linked list
 
+```solidity focus=2
+removeOwner(
+    "0x...",
+    "0x...",
+    1
+)
+```
+
 ### `owner`
 
 - **Type:** `address`
 
 Owner address to be removed.
 
+```solidity focus=3
+removeOwner(
+    "0x...",
+    "0x...",
+    1
+)
+```
+
 ### `_threshold`
 
 - **Type:** `uint256`
 
 New threshold.
 
+```solidity focus=4
+removeOwner(
+    "0x...",
+    "0x...",
+    1
+)
+```
+
 ## Events
 
 ### `RemovedOwner`

diff --git a/pages/reference-smart-account/owners/swapOwner.mdx b/pages/reference-smart-account/owners/swapOwner.mdx
@@ -2,11 +2,6 @@ import { Tabs, Callout } from "nextra/components"
 
 # `swapOwner`
 
-```solidity
-function swapOwner(address prevOwner, address oldOwner, address newOwner) external
-
-```
-
 Replaces the owner `oldOwner` in the Safe with `newOwner`.
 
 <Callout type="warning">
@@ -20,6 +15,10 @@ This can only be done via a Safe transaction.
 <Tabs items={['example.sol']}>
   <Tabs.Tab>
     ```solidity
+    interface ISafe {
+        function swapOwner(address prevOwner, address oldOwner, address newOwner) external
+    }
+
     contract Example {
         function example() … {
             (ISafe safe).swapOwner("0x...", "0x...", "0x...");
@@ -37,16 +36,40 @@ This can only be done via a Safe transaction.
 
 Owner that pointed to the owner to be replaced in the linked list
 
+```solidity focus=2
+swapOwner(
+    "0x...",
+    "0x...",
+    "0x..."
+)
+```
+
 ### `oldOwner`
 - **Type:** `address`
 
 Owner address to be replaced.
 
+```solidity focus=3
+swapOwner(
+    "0x...",
+    "0x...",
+    "0x..."
+)
+```
+
 ### `newOwner`
 - **Type:** `address`
 
 New owner address.
 
+```solidity focus=4
+swapOwner(
+    "0x...",
+    "0x...",
+    "0x..."
+)
+```
+
 ## Events
 
 ### [`AddedOwner`](./addOwnerWithThreshold.mdx#addedowner)