Skip to content

Commit

Permalink
Add latest changes
Browse files Browse the repository at this point in the history
  • Loading branch information
dasanra committed Nov 29, 2023
1 parent 29d4970 commit 3012b3a
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions safe-core-sdk/protocol-kit/reference/migrating/v1.md
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,9 @@ You can remove `@safe-global/safe-web3-lib` from your `package.json` after this

There are type changes affecting web3 and ethers adapter libraries.

Check failure on line 59 in safe-core-sdk/protocol-kit/reference/migrating/v1.md

View workflow job for this annotation

GitHub Actions / vale

[vale] safe-core-sdk/protocol-kit/reference/migrating/v1.md#L59

[write-good.ThereIs] Don't start a sentence with 'There are'.
Raw output
{"message": "[write-good.ThereIs] Don't start a sentence with 'There are'.", "location": {"path": "safe-core-sdk/protocol-kit/reference/migrating/v1.md", "range": {"start": {"line": 59, "column": 1}}}, "severity": "ERROR"}

`getSafeContract`, `getMultisendContract`, `getMultisendCallOnlyContract`, `getCompatibilityFallbackHandlerContract`, `getSafeProxyFactoryContract`, `getSignMessageLibContract` and `getCreateCallContract` don't need the `chainId` parameter any more, they will use the provider connected one. Also they will return a `Promise` now.
`getSafeContract`, `getMultisendContract`, `getMultisendCallOnlyContract`, `getCompatibilityFallbackHandlerContract`, `getSafeProxyFactoryContract`, `getSignMessageLibContract` and `getCreateCallContract` don't need the `chainId` parameter any more, they will use the chain set on the provider. Also they return a `Promise` now.

`estimateGas` will return now a `string` instead of a `number`
`estimateGas` returns now a `string` instead of a `number`

## `safeFactory.deploySafe()`

Expand Down Expand Up @@ -96,3 +96,7 @@ const safeAddress = safeSdk.getAddress()
// new
const safeAddress = await protocolKit.getAddress()
```

## General types changes

If you set `safeTxGas`, `baseGas`, and `gasPrice` you must use `string` instead of `number`.

0 comments on commit 3012b3a

Please sign in to comment.