Add Authentication to Redis #2222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamacook
reviewed
Jan 3, 2025
src/config/entities/configuration.ts
Outdated
Comment on lines
310
to
311
| user: process.env.REDIS_USER || undefined, | ||
| pass: process.env.REDIS_PASS || undefined, |
There was a problem hiding this comment.
These are undefined by default.
Suggested change
| user: process.env.REDIS_USER || undefined, | |
| pass: process.env.REDIS_PASS || undefined, | |
| user: process.env.REDIS_USER, | |
| pass: process.env.REDIS_PASS, |
Comment on lines
6
to
7
| REDIS_USER = undefined, | ||
| REDIS_PASS = undefined, |
There was a problem hiding this comment.
These are undefined by default.
Suggested change
| REDIS_USER = undefined, | |
| REDIS_PASS = undefined, | |
| REDIS_USER, | |
| REDIS_PASS, |
Comment on lines
207
to
208
| user: process.env.REDIS_USER || undefined, | ||
| pass: process.env.REDIS_PASS || undefined, |
There was a problem hiding this comment.
These are undefined by default.
Suggested change
| user: process.env.REDIS_USER || undefined, | |
| pass: process.env.REDIS_PASS || undefined, | |
| user: process.env.REDIS_USER, | |
| pass: process.env.REDIS_PASS, |
@iamacook Well, since we haven't decided to enable authentication I haven't included them in the compose file yet. Edit: Sample file updated |
iamacook
approved these changes
Jan 6, 2025
iamacook
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds authentication support for Redis in the application. It configures Redis connections to include authentication credentials, ensuring secure access to the Redis instance
Changes