Trigger notification dispatch tests by queue #2216
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamacook
commented
Dec 19, 2024
Comment on lines
+142
to
+145
| reorgDetectedEventBuilder().build(), | ||
| newDelegateEventBuilder().build(), | ||
| updatedDelegateEventBuilder().build(), | ||
| deletedDelegateEventBuilder().build(), |
There was a problem hiding this comment.
These were added as they were missing.
iamacook
commented
Dec 19, 2024
| @@ -2017,7 +2024,7 @@ describe.skip('Post Hook Events for Notifications (Unit)', () => { | |||
| } | |||
| }); | |||
|
|
|||
| pushNotificationsApi.enqueueNotification | |||
| notificationsRepository.enqueueNotification | |||
There was a problem hiding this comment.
As we are mocking the repository, it's's not possible to test this as the logic is inside the method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Our notifications are dispatched in accordance with queue events. Most of the test coverage was linked to our previous POST hooks, and therefore skipped.
This converts the tests to trigger via queue instead of POST calls, unskipping them.
Changes