Trigger cache invalidation tests by queue #2215
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamacook
commented
Dec 19, 2024
Comment on lines
-101
to
-251
| txHash: faker.string.hexadecimal({ length: 32 }), | ||
| }, | ||
| { | ||
| type: 'MESSAGE_CREATED', | ||
| address: faker.finance.ethereumAddress(), | ||
| messageHash: faker.string.hexadecimal({ length: 32 }), | ||
| }, | ||
| { | ||
| type: 'MESSAGE_CONFIRMATION', | ||
| address: faker.finance.ethereumAddress(), | ||
| messageHash: faker.string.hexadecimal({ length: 32 }), | ||
| }, | ||
| { | ||
| type: 'CHAIN_UPDATE', | ||
| }, | ||
| { | ||
| type: 'REORG_DETECTED', | ||
| chainId: faker.string.numeric(), | ||
| blockNumber: faker.number.int(), | ||
| }, | ||
| { | ||
| type: 'SAFE_APPS_UPDATE', | ||
| }, | ||
| { | ||
| type: 'SAFE_CREATED', | ||
| address: faker.finance.ethereumAddress(), | ||
| blockNumber: faker.number.int(), | ||
| }, | ||
| ])('accepts $type', async (payload) => { | ||
| const chainId = faker.string.numeric(); | ||
| const data = { | ||
| chainId: chainId, | ||
| ...payload, | ||
| }; | ||
| networkService.get.mockImplementation(({ url }) => { | ||
| switch (url) { | ||
| case `${safeConfigUrl}/api/v1/chains/${chainId}`: | ||
| return Promise.resolve({ | ||
| data: rawify(chainBuilder().with('chainId', chainId).build()), | ||
| status: 200, | ||
| }); | ||
| default: | ||
| return Promise.reject(new Error(`Could not match ${url}`)); | ||
| } | ||
| }); | ||
|
|
||
| await request(app.getHttpServer()) | ||
| .post(`/hooks/events`) | ||
| .set('Authorization', `Basic ${authToken}`) | ||
| .send(data) | ||
| .expect(202); | ||
| }); | ||
|
|
||
| it('returns 400 (Bad Request) on unknown payload', async () => { | ||
| const data = { | ||
| type: 'SOME_TEST_TYPE_THAT_WE_DO_NOT_SUPPORT', | ||
| safeTxHash: 'some-safe-tx-hash', | ||
| }; | ||
| networkService.get.mockImplementation(({ url }) => { | ||
| switch (url) { | ||
| case `${safeConfigUrl}/api/v1/chains/1`: | ||
| return Promise.resolve({ | ||
| data: rawify(chainBuilder().with('chainId', '1').build()), | ||
| status: 200, | ||
| }); | ||
| default: | ||
| return Promise.reject(new Error(`Could not match ${url}`)); | ||
| } | ||
| }); | ||
|
|
||
| await request(app.getHttpServer()) | ||
| .post(`/hooks/events`) | ||
| .set('Authorization', `Basic ${authToken}`) | ||
| .send(data) | ||
| .expect(422) | ||
| .expect({ | ||
| statusCode: 422, | ||
| code: 'invalid_union_discriminator', | ||
| options: [ | ||
| 'CHAIN_UPDATE', | ||
| 'DELETED_MULTISIG_TRANSACTION', | ||
| 'EXECUTED_MULTISIG_TRANSACTION', | ||
| 'INCOMING_ETHER', | ||
| 'INCOMING_TOKEN', | ||
| 'MESSAGE_CREATED', | ||
| 'MODULE_TRANSACTION', | ||
| 'NEW_CONFIRMATION', | ||
| 'MESSAGE_CONFIRMATION', | ||
| 'OUTGOING_ETHER', | ||
| 'OUTGOING_TOKEN', | ||
| 'PENDING_MULTISIG_TRANSACTION', | ||
| 'REORG_DETECTED', | ||
| 'SAFE_APPS_UPDATE', | ||
| 'SAFE_CREATED', | ||
| ], | ||
| path: ['type'], | ||
| message: | ||
| "Invalid discriminator value. Expected 'CHAIN_UPDATE' | 'DELETED_MULTISIG_TRANSACTION' | 'EXECUTED_MULTISIG_TRANSACTION' | 'INCOMING_ETHER' | 'INCOMING_TOKEN' | 'MESSAGE_CREATED' | 'MODULE_TRANSACTION' | 'NEW_CONFIRMATION' | 'MESSAGE_CONFIRMATION' | 'OUTGOING_ETHER' | 'OUTGOING_TOKEN' | 'PENDING_MULTISIG_TRANSACTION' | 'REORG_DETECTED' | 'SAFE_APPS_UPDATE' | 'SAFE_CREATED'", | ||
| }); | ||
| }); |
There was a problem hiding this comment.
These were removed as we receive no response. If we want to check this, however, we could check whether an error is logged.
iamacook
commented
Dec 19, 2024
Comment on lines
+936
to
+942
| it.each( | ||
| [ | ||
| newDelegateEventBuilder().build(), | ||
| updatedDelegateEventBuilder().build(), | ||
| deletedDelegateEventBuilder().build(), | ||
| ].map((event) => [event.type, event]), | ||
| )('%s clears delegates', async (_, event) => { |
There was a problem hiding this comment.
These were added as they were missing - initially marked with a TODO at the top.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Our cache is invalidated in accordance with queue events. Most of the test coverage was linked to our previous POST hooks, and therefore skipped.
This converts the tests to trigger via queue instead of POST calls, unskipping them.
Changes