Missing incoming transfers (#2006)

* submittedAt is null for incoming transfers. * Do not treat incoming transfers as pending. Or unknown
safe-global · Sep 1, 2023 · 2454c60 · 2454c60
1 parent 3ab7967
commit 2454c60
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/app/src/main/java/io/gnosis/safe/ui/transactions/TransactionListViewModel.kt b/app/src/main/java/io/gnosis/safe/ui/transactions/TransactionListViewModel.kt
@@ -121,9 +121,8 @@ class TransactionListViewModel
                 // that was submitted for execution
                 if (txLocal?.safeTxNonce == txListEntry.transaction.executionInfo?.nonce) {
                     // use submittedAt timestamp to distinguish between conflicting transactions
-                    if (txLocal?.submittedAt == txListEntry.transaction.timestamp.time && txListEntry.transaction.txStatus == TransactionStatus.AWAITING_EXECUTION) {
+                    if ((txLocal?.submittedAt == null || txLocal?.submittedAt == txListEntry.transaction.timestamp.time) && txListEntry.transaction.txStatus == TransactionStatus.AWAITING_EXECUTION) {
                         val tx = txListEntry.transaction.copy(txStatus = TransactionStatus.PENDING)
-                        txListEntry.transaction
                         getTransactionView(
                             chain = safe.chain,
                             transaction = tx,
@@ -133,7 +132,14 @@ class TransactionListViewModel
                             localOwners = owners
                         )
                     } else {
-                        TransactionView.Unknown
+                        getTransactionView(
+                            chain = safe.chain,
+                            transaction = txListEntry.transaction,
+                            safes = safes,
+                            needsYourConfirmation = false,
+                            isConflict = false,
+                            localOwners = owners
+                        )
                     }
                 } else {
                     val isConflict = txListEntry.conflictType != ConflictType.None