Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in create_objective_function #101

Closed
wants to merge 2 commits into from

Conversation

an-altosian
Copy link

  1. alphaWeight is not used anywhere in the function.
  2. The nodes column in the weights dataframe always contains integers instead of the actual node names.
  3. According to cplex, the maximum length of each line is 560, see here.

@an-altosian an-altosian changed the title Fix bug in create_objective_function Fix bugg in create_objective_function Jan 23, 2025
@an-altosian an-altosian changed the title Fix bugg in create_objective_function Fix bugs in create_objective_function Jan 23, 2025
@gabora
Copy link
Member

gabora commented Jan 23, 2025

Hi @an-altosian,

Thank you for the proposed changes!

The alphaWeight was intentionally removed from the code. While it still appears as an input in some functions, it is not used anywhere. Accordingly, alphaWeight is not exposed to users and does not appear in the CARNIVALdefaultOptions.

I noticed that while the main branch passed the tests, the proposed pull request fails many unit tests on Linux:
[ FAIL 30 | WARN 0 | SKIP 14 | PASS 105 ]

Additionally, please note that we are not actively developing or maintaining the R version of CARNIVAL. For a more up-to-date and actively supported framework, we recommend checking out CORNETO, a Python-based implementation.

Best regards,

@gabora gabora closed this Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants