Show bank a/c details #1913
Open
Show bank a/c details #1913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apoorv1316
reviewed
Oct 24, 2024
There was a problem hiding this comment.
@Shruti-Apte Please rebase from backend branch, fix review comments and test the changes. Also add a loom video with bank account details and without bank account details.
app/javascript/src/components/ClientInvoices/Details/InvoiceDetails.tsx
Outdated
Show resolved
Hide resolved
added 3 commits
October 28, 2024 09:38
…b.com/saeloun/miru-web into show_bank_a/c_details Merge with backend branch
…b.com/saeloun/miru-web into show_bank_a/c_details pulled backend changes
apoorv1316
reviewed
Nov 4, 2024
| .min(12, "Account number must have 12 characters"), | ||
| accountType: Yup.string().required("Account type cannot be blank"), | ||
| }); | ||
|
|
There was a problem hiding this comment.
@Shruti-Apte Please confirm the validations for routing number and account number with @sonamvg
Shruti-Apte
changed the base branch from
develop
to
show-bank-account-details-on-invoices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1890 (UI)
Preview:
https://www.loom.com/share/0e1539e1a1d644b99342e187fac945b6?sid=67cf9645-833d-4ad3-8e19-19a6f455b4b9
Backend changes from PR are also included