Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: apply php-cs-fixer 3.64 changes #672

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

phil-davis
Copy link
Contributor

https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/releases/tag/v3.64.0 adds to the code-style config of "Symfony"

There are now checks for stuff like "single space after" PHP-CS-Fixer/PHP-CS-Fixer#8171
and trailing_comma_in_multiline PHP-CS-Fixer/PHP-CS-Fixer#8161

These changes are all fine for PHP 7.4 and up.

This is needed to get CI passing with the new php-cs-fixer 3.64.

@phil-davis phil-davis merged commit fad6391 into sabre-io:master Sep 4, 2024
6 checks passed
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.76%. Comparing base (8888958) to head (57492ab).
Report is 5 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #672      +/-   ##
============================================
- Coverage     98.78%   98.76%   -0.03%     
  Complexity     1874     1874              
============================================
  Files            71       71              
  Lines          5270     5343      +73     
============================================
+ Hits           5206     5277      +71     
- Misses           64       66       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant