Backport from master branch #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [actions/cache](https://github.com/actions/cache) from 3 to 4. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@v3...v4) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3 to 4. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v3...v4) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Luc DUZAN <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.5 #659 +/- ##
============================================
- Coverage 98.57% 98.38% -0.20%
+ Complexity 1898 1813 -85
============================================
Files 71 71
Lines 5483 4334 -1149
============================================
- Hits 5405 4264 -1141
+ Misses 78 70 -8 ☔ View full report in Codecov by Sentry. |
phil-davis
force-pushed
the
backport-20240530
branch
from
eb2c41e
to
412870a
Compare
phil-davis
force-pushed
the
backport-20240530
branch
from
ffeddd5
to
0efa81b
Compare
staabm
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport changes from master that have happened since release https://github.com/sabre-io/vobject/releases/tag/4.5.4 on 2023-11-09
These come from PRs
#632 Add PHP 8.3 to CI
#637 Bump GitHub workflow actions/cache to 4
#638 Bump codecov/codecov-action to 4
#649 add lineIndex and lineString properties to a Property Node
#652 ITip\Broker: handle timezones in replies to exception events
#654 chore: stop exporting php-cs-fixer config
#656 Yearly rrule compliance by the iterator
#658 throw ParseException when null input is provided
I had to remove some code like
?intthat does not work on PHP 7.1 (just declare the parameterint). But everything seems to work right back to PHP 7.1, and all tests pass.This keeps the 4.5 branch up-to-date with fixes/changes that are pending release.