Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Issue467Test.php #622

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Create Issue467Test.php #622

merged 1 commit into from
Nov 9, 2023

Conversation

sash04ek
Copy link
Contributor

added test for the #467 issue

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #622 (9627731) into master (c832cc3) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #622   +/-   ##
=========================================
  Coverage     98.76%   98.76%           
  Complexity     1866     1866           
=========================================
  Files            71       71           
  Lines          5325     5325           
=========================================
  Hits           5259     5259           
  Misses           66       66           

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@phil-davis
Copy link
Contributor

I added a small test to PR #619 which demonstrates the problem and passes with the fix.

@DeepDiver1975 @staabm do we want a higher-level test like the one in this PR?

@DeepDiver1975
Copy link
Member

I think both tests are valid as they operate on different levels.

@phil-davis phil-davis merged commit 47ad4b9 into sabre-io:master Nov 9, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants