Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: install evm utils #1167

Merged
merged 4 commits into from
Feb 11, 2025
Merged

build: install evm utils #1167

merged 4 commits into from
Feb 11, 2025

Conversation

andreivladbrg
Copy link
Member

@andreivladbrg andreivladbrg commented Feb 4, 2025

Closes #1125

Depends on #1166

@andreivladbrg andreivladbrg marked this pull request as draft February 4, 2025 17:24
@andreivladbrg andreivladbrg force-pushed the build/install-evm-utils branch 2 times, most recently from e3d5847 to ac56038 Compare February 4, 2025 20:36
@andreivladbrg andreivladbrg marked this pull request as ready for review February 5, 2025 16:42
@smol-ninja smol-ninja force-pushed the refactor/remove-broker branch from 1a5eeb2 to 8236b66 Compare February 6, 2025 13:46
Base automatically changed from refactor/remove-broker to staging February 6, 2025 23:15
@smol-ninja
Copy link
Member

@andreivladbrg can you plz resolve the conflict on this PR?

@andreivladbrg andreivladbrg force-pushed the build/install-evm-utils branch 3 times, most recently from 93bc36b to 01308a4 Compare February 10, 2025 21:59
refactor: remove Adminable logic from this repo
refactor: remove Batch logic from this repo
refactor: remove NoDelegateCall logic from this repo

refactor: use BaseScript from evm-utils

build: update evm utils

test: use evm utils common tests
test: remove mocks

refactor: remove no longer needed errors
@andreivladbrg andreivladbrg force-pushed the build/install-evm-utils branch from 01308a4 to 21aaee2 Compare February 10, 2025 22:04
@andreivladbrg
Copy link
Member Author

@andreivladbrg can you plz resolve the conflict on this PR?

just resolved them

Copy link
Member

@smol-ninja smol-ninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on the PR. It looks cleaner with evm-utils.

package.json Outdated Show resolved Hide resolved
script/MaxCount.s.sol Show resolved Hide resolved
tests/utils/Constants.sol Outdated Show resolved Hide resolved
tests/utils/BaseScript.t.sol Outdated Show resolved Hide resolved
tests/utils/Defaults.sol Show resolved Hide resolved
tests/Base.t.sol Outdated Show resolved Hide resolved
tests/integration/concrete/constructor.t.sol Outdated Show resolved Hide resolved
tests/integration/concrete/constructor.t.sol Outdated Show resolved Hide resolved
@smol-ninja
Copy link
Member

Also, the coverage has gone down.

@andreivladbrg
Copy link
Member Author

Also, the coverage has gone down

not sure why

test: declare the date in Defaults
Copy link
Member

@smol-ninja smol-ninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re. coverage, lets look into it later. LGTM now.

@andreivladbrg andreivladbrg merged commit ef3bc49 into staging Feb 11, 2025
2 checks passed
@andreivladbrg andreivladbrg deleted the build/install-evm-utils branch February 11, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants