-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: install evm utils #1167
build: install evm utils #1167
Conversation
e3d5847
to
ac56038
Compare
1a5eeb2
to
8236b66
Compare
@andreivladbrg can you plz resolve the conflict on this PR? |
93bc36b
to
01308a4
Compare
refactor: remove Adminable logic from this repo refactor: remove Batch logic from this repo refactor: remove NoDelegateCall logic from this repo refactor: use BaseScript from evm-utils build: update evm utils test: use evm utils common tests test: remove mocks refactor: remove no longer needed errors
01308a4
to
21aaee2
Compare
just resolved them |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on the PR. It looks cleaner with evm-utils.
Also, the coverage has gone down. |
not sure why |
test: declare the date in Defaults
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re. coverage, lets look into it later. LGTM now.
Closes #1125
Depends on #1166