Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove protocol fee #385

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Conversation

andreivladbrg
Copy link
Member

@andreivladbrg andreivladbrg commented Feb 5, 2025

Closes #366

Depends on #384

test: fix failing tests

test: remove unused imports

test: remove commented lines

test: deploy the flow contract in fork tests
@andreivladbrg andreivladbrg marked this pull request as draft February 5, 2025 11:29
@smol-ninja smol-ninja force-pushed the refactor/remove-broker branch from 4aad3fb to e008bde Compare February 7, 2025 14:41
Base automatically changed from refactor/remove-broker to staging February 10, 2025 22:06
@andreivladbrg andreivladbrg force-pushed the refactor/remove-protocol-fee branch 3 times, most recently from 13bb6f2 to 5b03362 Compare February 10, 2025 22:24
@andreivladbrg andreivladbrg marked this pull request as ready for review February 10, 2025 22:27
@smol-ninja smol-ninja force-pushed the refactor/remove-protocol-fee branch from 6ab7f0c to c3f88c6 Compare February 11, 2025 12:55
Copy link
Member

@smol-ninja smol-ninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good except one question.

tests/utils/Constants.sol Show resolved Hide resolved
@andreivladbrg
Copy link
Member Author

andreivladbrg commented Feb 11, 2025

your commit will cause conflicts in the next PR 🙈
we will remove the FEE

@smol-ninja
Copy link
Member

smol-ninja commented Feb 11, 2025

your commit will cause conflicts in the next PR

Oh sorry. But I guess it will be a very small one as I only changed one line. 😅 Feel free to revert it back.

@andreivladbrg andreivladbrg force-pushed the refactor/remove-protocol-fee branch from c09f0e7 to c3f88c6 Compare February 11, 2025 15:59
@andreivladbrg andreivladbrg merged commit 5edf5d6 into staging Feb 11, 2025
11 checks passed
@andreivladbrg andreivladbrg deleted the refactor/remove-protocol-fee branch February 11, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants