Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Sort notes and folders in recent and browse pages #1408

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Edgiest05
Copy link

Introduced a button SortButton located at the top-right of the UI in recent and browse pages (near the syncing one):
button

When pressed it shows a dropdown for a predetermined selection, provided in the static class SortNotes.
Such selection is preserved as a preference and is kept on app restart.
dropdown

Sdk version change is not related to my own implementation, but instead is a workaround to compilation errors that made it impossible to test on android emulator.

Copy link

codecov bot commented Dec 1, 2024

Codecov Report

Attention: Patch coverage is 20.47244% with 101 lines in your changes missing coverage. Please review.

Project coverage is 47.03%. Comparing base (10d1906) to head (f21e159).

Files with missing lines Patch % Lines
lib/components/home/sort_button.dart 17.89% 78 Missing ⚠️
lib/pages/home/browse.dart 0.00% 20 Missing ⚠️
lib/pages/home/recent_notes.dart 62.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1408      +/-   ##
==========================================
- Coverage   47.39%   47.03%   -0.37%     
==========================================
  Files         114      115       +1     
  Lines        8959     9077     +118     
==========================================
+ Hits         4246     4269      +23     
- Misses       4713     4808      +95     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant