Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ratelimit on both api handlers and TRPC route on user route #30

Merged
merged 5 commits into from
Feb 22, 2024

Conversation

Kinfe123
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Feb 20, 2024

Someone is attempting to deploy a commit to a Personal Account owned by @iamtouha on Vercel.

@iamtouha first needs to authorize it.

@Fr3akyMurk
Copy link
Contributor

Don't really like the idea of using Upstash, but i am just biased.
I don't like dependencies that may or may not ask for money later down the road.

but otherwise it looks good.

@Kinfe123
Copy link
Contributor Author

Kinfe123 commented Feb 20, 2024

yeah but as long as you are starting out for quick stuff you need to get to well maintained and support rich package that can help you accelerate rather than implementing the native and maintaining the edgecase for different kind of rate limiting startegy :)

But you cleary have the point and i also want to do it with native LRU cache method to acheive this or sth like that;)

@Fr3akyMurk
Copy link
Contributor

You do have a good point, wasting time on something that is already done isn't ideal unless you already have a stable project that doesn't really need heavy work anymore.

If you can get that native LRU stuff going then i can guarantee that this project would be the only one with this feature.
(No one else has done it in a public repo that i am aware of)

Copy link

vercel bot commented Feb 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
t3-lucia-starter ❌ Failed (Inspect) Feb 20, 2024 6:10pm

@Kinfe123 Kinfe123 changed the title Ratelimit on both api handlers and TRPC route on user route added Ratelimit on both api handlers and TRPC route on user route Feb 22, 2024
@iamtouha iamtouha changed the base branch from main to upstash-ratelimiting February 22, 2024 15:18
@iamtouha iamtouha merged commit e4305d0 into saasykits:upstash-ratelimiting Feb 22, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants