docs: add High Availability information for s3gw and Longhorn #845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giubacc
added
kind/documentation
tserong
reviewed
Nov 29, 2023
Fixes: https://github.com/aquarist-labs/s3gw/issues/841 Signed-off-by: Giuseppe Baccini <[email protected]>
giubacc
force-pushed
the
docs-current-HA-s3gw-LH
branch
from
1fd7299 to
126b7a0
Compare
jecluis
requested changes
Nov 29, 2023
Comment on lines
+18
to
+19
| s3gw can reasonably protect against; that's all undefined behavior and "restore | ||
| from backup" time. |
There was a problem hiding this comment.
I think we can drop the that's all undefined behavior ..., or maybe replace it with just In this case, restoring from backup might be the only option..
| s3gw can reasonably protect against; that's all undefined behavior and "restore | ||
| from backup" time. | ||
|
|
||
| The *Active/Standby* model claims the following characteristics: |
| This has the advantage of being schedulable, so it can happen at times of low load | ||
| if these exist. | ||
|
|
||
| When any of these scenarios should happen, Kubernetes restarts the s3gw pod and we |
Comment on lines
+47
to
+48
| writing this), does not automatically restart a pod attached to a RWO volume | ||
| in the event that the node running it suffers a failure. |
There was a problem hiding this comment.
I'd write "in case the node it is running on suffers from a failure"
| Currently, Kubernetes ([1.28](https://kubernetes.io/releases/) at the time of | ||
| writing this), does not automatically restart a pod attached to a RWO volume | ||
| in the event that the node running it suffers a failure. | ||
| Reasons behind this behavior is that workloads, such as RWO volumes require |
There was a problem hiding this comment.
add a comma between "RWO volumes" and "require"?
| Failures affecting these kind of workloads risk data loss and/or corruption | ||
| if nodes (and the workloads running on them) are wrongly assumed to be dead. | ||
| For this reason it is crucial to know that the node has reached a safe state | ||
| before initiating recovery of the workload. |
There was a problem hiding this comment.
s/recovery of the workload/workload recovery/
Comment on lines
+56
to
+57
| Longhorn offers the option to perform a [Pod Deletion Policy][pod-deletion-policy] | ||
| when a node should go down unexpectedly. |
There was a problem hiding this comment.
I'd write instead
offers the option to define a Pod Deletion Policy when the node goes down unexpectedly
|
|
||
| Longhorn offers the option to perform a [Pod Deletion Policy][pod-deletion-policy] | ||
| when a node should go down unexpectedly. | ||
| This means that Longhorn will force delete StatefulSet/Deployment terminating pods |
There was a problem hiding this comment.
you mean "force-delete" or something? or maybe "forcefully delete"?
| on nodes that are down to release Longhorn volumes so that Kubernetes | ||
| can spin up replacement pods. | ||
|
|
||
| Anyway, when employing this mitigation, the user must be aware that assuming a node |
There was a problem hiding this comment.
Maybe drop the "Anyway" and start with "When employing ..." ?
|
|
||
| The s3gw and the Longhorn team is currently investigating some | ||
| [hypotheses of solutions][longhorn-issue-1] | ||
| to address this problem at its roots. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add High Availability information for s3gw and Longhorn
Fixes: https://github.com/aquarist-labs/s3gw/issues/841
Checklist before requesting a review