Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose prefixed seed credential env variables with S3GW_ #836

Closed

Conversation

giubacc
Copy link

@giubacc giubacc commented Nov 23, 2023

expose 'S3GW_' prefixed seed credential env variables to the user instead of 'RGW_' prefixed env vars.

entrypoint.sh can be invoked setting the following env vars (both RGW_* and S3GW_* work equally):

RGW_DEFAULT_USER_ID             S3GW_DEFAULT_USER_ID
RGW_DEFAULT_USER_DISPLAY_NAME   S3GW_DEFAULT_USER_DISPLAY_NAME
RGW_DEFAULT_USER_EMAIL          S3GW_DEFAULT_USER_EMAIL
RGW_DEFAULT_USER_ACCESS_KEY     S3GW_DEFAULT_USER_ACCESS_KEY
RGW_DEFAULT_USER_SECRET_KEY     S3GW_DEFAULT_USER_SECRET_KEY
RGW_DEFAULT_USER_CAPS           S3GW_DEFAULT_USER_CAPS
RGW_DEFAULT_USER_SYSTEM         S3GW_DEFAULT_USER_SYSTEM

entrypoint.sh --help will show the description for the S3GW_* aliases.

Fixes: https://github.com/aquarist-labs/s3gw/issues/767

Describe your changes

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • CHANGELOG.md has been updated should there be relevant changes in this PR.

expose 'S3GW_' prefixed seed credential env variables to the user
instead of 'RGW_' prefixed env vars.

entrypoint.sh can be invoked setting the following env vars (both RGW_*
and S3GW_* work equally):

RGW_DEFAULT_USER_ID             S3GW_DEFAULT_USER_ID
RGW_DEFAULT_USER_DISPLAY_NAME   S3GW_DEFAULT_USER_DISPLAY_NAME
RGW_DEFAULT_USER_EMAIL          S3GW_DEFAULT_USER_EMAIL
RGW_DEFAULT_USER_ACCESS_KEY     S3GW_DEFAULT_USER_ACCESS_KEY
RGW_DEFAULT_USER_SECRET_KEY     S3GW_DEFAULT_USER_SECRET_KEY
RGW_DEFAULT_USER_CAPS           S3GW_DEFAULT_USER_CAPS
RGW_DEFAULT_USER_SYSTEM         S3GW_DEFAULT_USER_SYSTEM

entrypoint.sh --help will show the description for the S3GW_* aliases.

Fixes: https://github.com/aquarist-labs/s3gw/issues/767
Signed-off-by: Giuseppe Baccini <[email protected]>
@giubacc giubacc requested a review from jecluis November 23, 2023 14:32
@giubacc giubacc added this to the v0.24.0 milestone Nov 23, 2023
@giubacc giubacc self-assigned this Nov 23, 2023
@giubacc giubacc added kind/quality Quality improvements, Refactoring, Automation via CI, E2E, Integration, CLI or REST API priority/1 Should be fixed for next release labels Nov 23, 2023
@jecluis jecluis removed this from the v0.24.0 milestone Mar 21, 2024
@jecluis jecluis closed this Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/quality Quality improvements, Refactoring, Automation via CI, E2E, Integration, CLI or REST API priority/1 Should be fixed for next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants