Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display a meaningful error message #304

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

votdev
Copy link
Contributor

@votdev votdev commented Nov 28, 2023

... in case there are any connection related errors.

Bildschirmfoto vom 2023-11-28 12-06-39

Fixes: https://github.com/aquarist-labs/s3gw/issues/823

@votdev votdev added kind/enhancement Add more things to something area/ui User Interface labels Nov 28, 2023
@votdev votdev added this to the v0.24.0 milestone Nov 28, 2023
@votdev votdev self-assigned this Nov 28, 2023
@votdev votdev requested a review from jecluis November 28, 2023 11:12
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0e5df4a) 98.85% compared to head (580a136) 98.86%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #304   +/-   ##
=======================================
  Coverage   98.85%   98.86%           
=======================================
  Files          15       15           
  Lines        1047     1053    +6     
=======================================
+ Hits         1035     1041    +6     
  Misses         12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@votdev votdev force-pushed the issue_826_useful_err_msg branch 2 times, most recently from 7b110db to b29f5a0 Compare November 28, 2023 11:21
... in case there are any connection related errors.

Fixes: https://github.com/aquarist-labs/s3gw/issues/823

Signed-off-by: Volker Theile <[email protected]>
@votdev votdev force-pushed the issue_826_useful_err_msg branch from b29f5a0 to 580a136 Compare November 28, 2023 11:23
@votdev votdev merged commit 02712b5 into s3gw-tech:main Nov 29, 2023
8 checks passed
@votdev votdev deleted the issue_826_useful_err_msg branch November 29, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui User Interface kind/enhancement Add more things to something
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI: 500 on login / Name does not resolve in backend
1 participant