Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add frontend e2e tests to gh workflow #303

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

Ameenasuhani
Copy link
Contributor

Describe your changes

Add frontend e2e tests to gh workflow

Issue ticket number and link

https://github.com/aquarist-labs/s3gw/issues/773

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • CHANGELOG.md has been updated should there be relevant changes in this PR

Signed-off-by: ameenasuhani <[email protected]>
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0e5df4a) 98.85% compared to head (b29d9f0) 98.85%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #303   +/-   ##
=======================================
  Coverage   98.85%   98.85%           
=======================================
  Files          15       15           
  Lines        1047     1047           
=======================================
  Hits         1035     1035           
  Misses         12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@m-ildefons m-ildefons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ameenasuhani Ameenasuhani merged commit 6eea5b9 into s3gw-tech:main Nov 30, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants