Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: The prefix handling is buggy at several places in the REST API #299

Merged
merged 2 commits into from
Nov 24, 2023

Conversation

votdev
Copy link
Contributor

@votdev votdev commented Nov 23, 2023

Fixes: https://github.com/aquarist-labs/s3gw/issues/831

Describe your changes

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • CHANGELOG.md has been updated should there be relevant changes in this PR

@votdev votdev added kind/bug Something isn't working area/ui User Interface labels Nov 23, 2023
@votdev votdev added this to the v0.24.0 milestone Nov 23, 2023
@votdev votdev self-assigned this Nov 23, 2023
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eb05116) 98.86% compared to head (46fe1da) 98.85%.
Report is 3 commits behind head on main.

❗ Current head 46fe1da differs from pull request most recent head 83c4fe7. Consider uploading reports for the commit 83c4fe7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #299      +/-   ##
==========================================
- Coverage   98.86%   98.85%   -0.02%     
==========================================
  Files          15       15              
  Lines        1061     1047      -14     
==========================================
- Hits         1049     1035      -14     
  Misses         12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@votdev votdev force-pushed the issue_831_prefixes branch 2 times, most recently from 8e7aace to 46fe1da Compare November 24, 2023 09:29
@votdev votdev marked this pull request as ready for review November 24, 2023 09:55
@votdev votdev force-pushed the issue_831_prefixes branch from 46fe1da to 83c4fe7 Compare November 24, 2023 10:02
@votdev votdev merged commit fa8e1b8 into s3gw-tech:main Nov 24, 2023
6 checks passed
@votdev votdev deleted the issue_831_prefixes branch November 24, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui User Interface kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI: The prefix handling is buggy at several places in the REST API
1 participant