Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle upload errors correctly #293

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Conversation

votdev
Copy link
Contributor

@votdev votdev commented Nov 21, 2023

Modify the success message if the number of loaded files is lower than the total number of uploaded files. This is the case when one or several file uploads failed.

Peek 2023-11-21 18-05

Fixes: https://github.com/aquarist-labs/s3gw/issues/818

Modify the success message if the number of loaded files is lower than the total number of uploaded files. This is the case when one or several file uploads failed.

Fixes: https://github.com/aquarist-labs/s3gw/issues/818

Signed-off-by: Volker Theile <[email protected]>
@votdev votdev added kind/enhancement Add more things to something area/ui User Interface labels Nov 21, 2023
@votdev votdev added this to the v0.24.0 milestone Nov 21, 2023
@votdev votdev requested a review from m-ildefons November 21, 2023 17:13
@votdev votdev self-assigned this Nov 21, 2023
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (706d644) 98.76% compared to head (9e1b905) 98.76%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #293   +/-   ##
=======================================
  Coverage   98.76%   98.76%           
=======================================
  Files          15       15           
  Lines        1050     1050           
=======================================
  Hits         1037     1037           
  Misses         13       13           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@votdev votdev requested a review from jecluis November 21, 2023 17:30
@votdev votdev merged commit 4dad4ba into s3gw-tech:main Nov 22, 2023
8 checks passed
@votdev votdev deleted the issue_818_handle_error branch November 22, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui User Interface kind/enhancement Add more things to something
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI] Incorrect handling of out of space condition
2 participants