Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement lingering for append record stream #55

Merged
merged 15 commits into from
Nov 18, 2024
Merged

feat: Implement lingering for append record stream #55

merged 15 commits into from
Nov 18, 2024

Conversation

vrongmeal
Copy link
Member

Resolves: #37

@vrongmeal vrongmeal mentioned this pull request Nov 13, 2024
Closed
@vrongmeal
cargo test
de41495 
Signed-off-by: Vaibhav Rabber <[email protected]>
@vrongmeal
fix doc test
44f6aa2 
Signed-off-by: Vaibhav Rabber <[email protected]>
@vrongmeal vrongmeal marked this pull request as ready for review November 13, 2024 11:35
@vrongmeal vrongmeal requested a review from a team as a code owner November 13, 2024 11:35
@vrongmeal
rename var
8130f37 
Signed-off-by: Vaibhav Rabber <[email protected]>
shikhar
shikhar reviewed Nov 13, 2024
View reviewed changes
src/streams.rs Outdated Show resolved Hide resolved
shikhar
shikhar reviewed Nov 13, 2024
View reviewed changes
src/streams.rs Outdated Show resolved Hide resolved
shikhar
shikhar reviewed Nov 13, 2024
View reviewed changes
src/streams.rs Outdated Show resolved Hide resolved
shikhar
shikhar reviewed Nov 13, 2024
View reviewed changes
src/streams.rs Outdated Show resolved Hide resolved
shikhar
shikhar reviewed Nov 13, 2024
View reviewed changes
src/streams.rs Outdated Show resolved Hide resolved
shikhar
shikhar reviewed Nov 13, 2024
View reviewed changes
src/streams.rs Outdated Show resolved Hide resolved
@vrongmeal
comments
e8222aa 
Signed-off-by: Vaibhav Rabber <[email protected]>
shikhar
shikhar reviewed Nov 14, 2024
View reviewed changes
src/streams.rs Outdated Show resolved Hide resolved
shikhar
shikhar reviewed Nov 14, 2024
View reviewed changes
src/streams.rs Outdated Show resolved Hide resolved
shikhar
shikhar reviewed Nov 14, 2024
View reviewed changes
src/streams.rs Outdated Show resolved Hide resolved
shikhar
shikhar reviewed Nov 14, 2024
View reviewed changes
src/streams.rs Outdated Show resolved Hide resolved
shikhar
shikhar reviewed Nov 14, 2024
View reviewed changes
src/streams.rs Outdated Show resolved Hide resolved
shikhar
shikhar reviewed Nov 14, 2024
View reviewed changes
src/streams.rs Outdated Show resolved Hide resolved
shikhar
shikhar reviewed Nov 14, 2024
View reviewed changes
src/streams.rs Outdated Show resolved Hide resolved
shikhar
shikhar reviewed Nov 14, 2024
View reviewed changes
src/streams.rs Outdated Show resolved Hide resolved
shikhar
shikhar reviewed Nov 14, 2024
View reviewed changes
src/streams.rs Outdated Show resolved Hide resolved
@vrongmeal
Copy link
Member Author

@shikhar Updated this as well. One final look?

@shikhar
Copy link
Member

shikhar commented Nov 15, 2024

I wanted to dig into the peeking logic, looking now!

Can we rename this mod to be more specific than streams? I think the function here really is batching, but not sure on that name.

shikhar
shikhar reviewed Nov 15, 2024
View reviewed changes
src/streams.rs Outdated Show resolved Hide resolved
shikhar
shikhar reviewed Nov 15, 2024
View reviewed changes
src/streams.rs Outdated Show resolved Hide resolved
@vrongmeal vrongmeal merged commit 7b85760 into main Nov 18, 2024
3 checks passed
@vrongmeal vrongmeal deleted the vrongmeal/lingering branch November 18, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shikhar shikhar shikhar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

linger time support for AppendRecordStream
2 participants
@vrongmeal @shikhar