Improve {lib,}jvm.{so,dylib,dll} loading #108
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the values from Makeconf to find java (Unix), falling back to JAVA_HOME (which is needed on Windows). Add the directory to PATH on Windows or dyn.load the shared library it on Linux. macOS is kept largely the same as it was except we check Makeconf before JAVA_HOME.
|
Can you provide any feedback @s-u? |
|
(I am now aware that Windows doesn't use this codepath btw) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For discussion: In the Anaconda Distribution (on Linux), we cannot set
LD_LIBRARY_PATHand also want to have as dynamic a Java configuration as possible (various Java implementations are available). On Windows we augment PATH before attempting to load the rJava DLL.Use the values from Makeconf to find java (Unix), falling back to JAVA_HOME (which is needed on Windows). Add the directory to PATH on Windows or dyn.load the shared library it on Linux. macOS is kept largely the same as it was except we check Makeconf before JAVA_HOME.
I hope this doesn't break lot of other things and that the approach is acceptable. I should state, I'm not much of an R programmer and so would welcome any and all feedback.