HandleFuncs can now be Type Methods as well. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`http.HandleFunc` documentation was not discovered because only
first class functions were traversed when building apib documentation.
Now both first class functions and type methods are traversed.
For example:
type WidgetController struct {}
// GetTypeWidget retrieves a single Widget
func (* WidgetController) GetWidget(w, r) { }
| @@ -1,12 +1,11 @@ | |||
| package test | |||
|
|
|||
| import ( | |||
| "github.com/adams-sarah/test2doc/doc/parse" | |||
There was a problem hiding this comment.
this should go back at the bottom with a newline separating it from std lib imports
|
Hey @ivaningrooves, I'd love to get your PR merged in. If you don't want to do my requested changes, I can do the changes myself. Would that work better for you? |
cj123
added a commit
to cj123/test2doc
that referenced
this pull request
Feb 25, 2018
…info function for gorilla/mux, using Walk to find the original http handler
|
@adams-sarah This PR seems to be abandoned. Are you planning to address issues mentioned above? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http.HandleFuncdocumentation was not discovered because onlyfirst class functions were traversed when building apib documentation.
Now both first class functions and type methods are traversed.
For example: