-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infra: Add AppImage build workflow #28
infra: Add AppImage build workflow #28
Conversation
Awesome! Yeah, I also think we could make the AppImage build process a standalone Bash script in build.yml is used for PR builds, we could probably include this directly in the release job for Linux x64 & arm64. I can look into it today or tomorrow. |
I thought about making it an standalone script but I could not figure out how to integrate that with the existing releases, so I added it to the build.yml to use the already produced binaries as base for the appimage and turns even that doesn't work 😅 I'm not sure what to do from here. |
Thanks so much for the help, merging this 😄 Will also add this to the release workflow! |
Thank you but there a few details, one is this mkdir making an extra empty bin dir. The other is that the appimage and appimage.zsync have to be released separately and not as a compressed tar.gz file, the appimage is already compressed and both need to be able to be downloaded directly from the releases. The .zsync file gets used for delta updates, that part of the script This also means since there is an aarch64 appimage being made, the update info would need to change for something like this:
That way appimageupdate doesn't get confused with the wrong .zsync file. edit you can also include the version the AppImage name, that is actually required by the appimage spec but isn't needed for appimageupdate to work, that is: |
This will produce an AppImage from the linux binaries, like I used to do here.
However I'm not sure how to include it in the release.yml 😅
Also this will only make an x86_64 AppImage.