-
-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: home page input form #279
base: master
Are you sure you want to change the base?
Conversation
@Jay-Karia is attempting to deploy a commit to the ryo-ma's Team Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Creating a form to fetch GitHub trophies is functional but can be improved for readability and efficiency. Firstly, the script tag appears redundant as no script content is included; it can be removed. Additionally, ensuring the placeholder text in the input field matches the button text for consistency is recommended. Here is the revised version:
<form action="https://github-profile-trophy.vercel.app/" method="get">
<label for="username">GitHub Username</label>
<input type="text" name="username" id="username" placeholder="Ex. gabriel-logan" required>
<button type="submit">Get Trophies</button>
</form>
This streamlined version improves readability and maintains functionality without unnecessary elements.
Cool, |
Updates the input form on the home page.