"Experience" trophy score threshold adjustments

[TurtleCode84]

Adjusted two of the score thresholds for the AccountDurationTrophy to be more accurate estimates of the durations in the code comments.

"Seasoned Veteran": 70 changed to 73 (20 years)
"Master Dev": 40 changed to 37 (10 years)

See #258 for additional discussion

[vercel]

@TurtleCode84 is attempting to deploy a commit to the ryo-ma's Team Team on Vercel.

A member of the Team first needs to authorize it.

[lulunac27a]

10 years is approximately 3652 to 3653 days and 20 years is approximately 7304 to 7305 days.
Divide this by 100 gives approximately 37 for 10 years and 73 for 20 years.

[TurtleCode84]

10 years is approximately 3652 to 3653 days and 20 years is approximately 7304 to 7305 days.

Right; in terms of math, I think I did something like 37 * 100 / 365.25 = 10.1300479124, which is closer to 10 years than 36 * 100 / 365.25 = 9.85626283368 (also assuming we're only using whole numbers for the thresholds).

Same concept for the 20 years.

[TurtleCode84]

@alexcastrodev Requesting review and any suggestions for improvement.

[alexcastrodev]

@alexcastrodev Requesting review and any suggestions for improvement.

Hi, Thanks for pinging me and taking time to improve the project :)
For the calculation, @ryo-ma knows behaviour of calculation better than me.

I have two points in this kind of solution:

1. It must be a Date / Intl calculation. I dont think we need every year review a PR to change a fixed variable.
2. After fix this calculation using native Date API, this must have testing for ensure we will not back again to this problem.

If you want to do it, go ahead.

[ryo-ma]

@TurtleCode84 I understand the argument.
However, I felt it would be better to modify the logic that calculates Duration Days.

github-profile-trophy/src/user_info.ts

Lines 87 to 89 in 7e5ec49

	const durationDays = Math.floor(
	durationTime / (1000 * 60 * 60 * 24) / 100,
	);

It's my fault for merging the above code.

[ryo-ma]

@bhavberi I feel that there is no need to calculate DurationDays by shortening it to 100 days.

[Imran-imtiaz48]

Review and Improvement Suggestions:
Consistency: Ensure consistency in naming conventions and formatting throughout your codebase. It helps maintain readability and reduces cognitive load when reviewing or modifying code.

Commenting: Comments like // 20 years and // 10 years are helpful for understanding the intent behind numeric values. Ensure these comments accurately reflect the logic or condition being set.

Testing: After making these changes, it's important to thoroughly test your code to ensure that the logic behaves as expected under various scenarios.

Version Control: Use version control effectively to track changes like these, making it easier to revert if necessary and to collaborate with others.

These adjustments should help in maintaining and improving the quality of your codebase.