-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge V1.4.0 #8
Merged
Merge V1.4.0 #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Separate classes FlexTonalPalette and FlexCorePalette to own files
Preparation step for more features in example app
ADD: Tone 97, extended size now 25 ADD: FlexTones.candyPop and FlexTones.chroma Add and update: Tests
Refactor: Error color defaults logic (unbreaking, but nicer logic and always match defaults) Change: candyPop and dark mode tones. this should be more popping and chromatic in dark mode.
Fix lints for Dart SDK and Flutter SDK bumps
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #8 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 35 39 +4
Lines 2303 2428 +125
==========================================
+ Hits 2303 2428 +125
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.4.0
July 2, 2023
NEW FEATURES
paletteType
ofFlexPaletteType
and set it toFlexPaletteType.extended
, by default its valuesFlexPaletteType.common
resulting in the 15 tones[0, 5, 10, 20, 30, 40, 50, 60, 70, 80, 90, 95, 98, 99, 100]
being produced as before.[0, 4, 5, 6, 10, 12, 17, 20, 22, 30, 40, 50, 60, 70, 80, 87, 90, 92, 94, 95, 96, 97, 98, 99, 100]
.paletteType
ofFlexPaletteType
are:FlexTonalPalette.of
FlexTonalPalette.fromList
FlexCorePalette.of
FlexCorePalette.fromHueChroma
FlexCorePalette.fromList
FlexCorePalette.fromSeeds
FlexTones
ColorScheme
, but since they are in the Material 3 spec, they will arrive at some later point.FlexTonalPalette
, like MCUTonalPalette
, caps chroma for tones higher than or equal to 90, to maximum chroma value of 40. InFlexTonalPalette
this still applies when usingFlexPaletteType.common
, when you use theFlexPaletteType.extended
, there is no chroma max cap on high tones, it uses fidelity mode for high tones. When using typeFlexPaletteType.common
the chroma of high tones (>= 90), is limited to maximum 40. This keeps the chromacity of tones 90 to 100, lower than 40. If the source uses has more chromacity than 40, there may be a sudden jump in chroma reduction at tone 90. This is the standard behavior for the original Material-3 tonal palette computation. TheFlexPaletteType.common
type is intended to be used when there is a need to follow strict M3's original palette design.FlexPaletteType.extended
type tones, there are not only the new tones, but the chroma limit of tones >= 90 is also removed. This increases fidelity of higher tone when high chromacity is used.FlexTones
s,candyPop
andchroma
, they use the newFlexPaletteType.extended
tonal palette.FlexTones
modifiersurfacesUseBW()
. It can be used as a modifier to force anyFlexTones
seed strategy to use tone 100 (white) or tone 0 (black) asbackground
andsurface
colors, depending on if they are dark or lightCHANGE
primaryContainerTone
andsecondaryContainerTone
for light modeFlexTones.highContrast
andFlexTones.ultraContrast
were both changed from 95 to 90. This produces brighter and more punchy themes for these two high-contrast themes in light mode.CHORE
EXAMPLE