Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add syntax definitions for container at rule #191

Conversation

vrugtehagel
Copy link
Contributor

@vrugtehagel vrugtehagel commented Jul 27, 2023

Related issue: #184

Adds support for @container.

Container queries are a tiny bit different from @media in syntax, since container queries allow an identifier (the container name) and not media-specific keyword (such as screen or print).

@vrugtehagel vrugtehagel changed the title Koendoodeman/add syntax definitions for container at rule Add syntax definitions for container at rule Jul 27, 2023
@vrugtehagel vrugtehagel mentioned this pull request Jul 27, 2023
4 tasks
Copy link
Collaborator

@argyleink argyleink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works great for me locally

Copy link
Collaborator

@argyleink argyleink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will merge after conflicts resolve 👍🏻

@vrugtehagel vrugtehagel force-pushed the koendoodeman/add-syntax-definitions-for-container-at-rule branch 2 times, most recently from b03c79f to 4e60a47 Compare August 2, 2023 07:04
@vrugtehagel vrugtehagel force-pushed the koendoodeman/add-syntax-definitions-for-container-at-rule branch from 4e60a47 to d7ddb65 Compare August 2, 2023 07:05
@vrugtehagel
Copy link
Contributor Author

Whoops, didn't notice the conflicts! Resolved now 😄

@argyleink argyleink merged commit b0876df into ryboe:master Aug 2, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants