Redundant call to start in ElasticSearchReporterFactoryBean

ryantenney · Jul 19, 2016 · d9bbb29 · d9bbb29
1 parent ed9396b
commit d9bbb29
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/main/java/com/ryantenney/metrics/spring/reporter/ElasticSearchReporterFactoryBean.java b/src/main/java/com/ryantenney/metrics/spring/reporter/ElasticSearchReporterFactoryBean.java
@@ -48,8 +48,6 @@ protected ElasticsearchReporter createInstance()
             .hosts(getProperty(ElasticSearchReporterElementParser.HOSTS, String[].class))
             .build();
 
-        elasticsearchReporter.start(getPeriod(), TimeUnit.NANOSECONDS);
-
         return elasticsearchReporter;
     }
 

diff --git a/src/test/resources/reporter-test.xml b/src/test/resources/reporter-test.xml
@@ -43,11 +43,13 @@
 	<metrics:reporter type="jmx" metric-registry="metrics" domain="com.foo" mbean-server-ref="mbeanServer" filter-ref="filter" rate-unit="MILLISECONDS" duration-unit="DAYS" />
 	<metrics:reporter type="newrelic" metric-registry="metrics" period="1m" name="new relic reporter" prefix="newrelic-test"/>
 	<metrics:reporter type="datadog" metric-registry="metrics" period="1m" transport="http" api-key="a12b3c" host="test" />
-	<metrics:reporter type="elasticsearch" metric-registry="metrics" period="1m" hosts="localhost:9200" additionalFieldsRef="additionalFields" />
 
+	<!--
+	<metrics:reporter type="elasticsearch" metric-registry="metrics" period="1m" hosts="localhost:9200" additionalFieldsRef="additionalFields" />
 	<util:map id="additionalFields">
 		<entry key="someKey" value="someValue" />
 	</util:map>
+	-->
 
 	<metrics:reporter id="graphite" type="graphite" metric-registry="metrics" period="100ms" host="localhost" port="6666" charset="ISO-8859-1" prefix="metrics-test" clock-ref="mockClock" filter-ref="filter" rate-unit="DAYS" duration-unit="HOURS" />
 	<metrics:reporter id="graphite-tcp" type="graphite" metric-registry="metrics" transport="tcp" period="100ms" host="localhost" port="6666" charset="ISO-8859-1" prefix="metrics-test" clock-ref="mockClock" filter-ref="filter" rate-unit="DAYS" duration-unit="HOURS" />