Verify custom onSuccess for generateThunk

src/createActionMethodNames.js

@@ -3,7 +3,7 @@ const DEFAULT_OPERATIONS = ['create', 'read', 'update', 'del', 'list'];
 export function getMethodName(base, operation) {
   // TODO: capitalize first char of base
   switch (operation) {
-    case: 'list':
+    case 'list':
       return `read${base}List`;
     default:
       return `${operation}${base}`;
@@ -12,4 +12,4 @@ export function getMethodName(base, operation) {
 
 export default function createActionMethodNames(base, operations = DEFAULT_OPERATIONS) {
   return operations.map(getMethodName.bind(base));
-}
+}

tests/redux-thunk/generateThunk.test.js

@@ -54,9 +54,9 @@ describe('generateThunk', function () {
       })
   });
 
-  it('generates thunk for `read` operation that dispatches all the actions', function () {
+  it('generates thunk for `update` operation that dispatches all the actions', function () {
     const options = {
-      operation: 'read',
+      operation: 'update',
       actions: createMockActions(),
       url: '/users/:id'
     };
@@ -70,15 +70,14 @@ describe('generateThunk', function () {
         expect(options.actions.success.calledOnce).to.equal(true);
         expect(dispatch.calledTwice).to.equal(true);
 
-        expect(config.ajax.getJSON.calledOnce);
-        expect(config.ajax.getJSON.firstCall.args[0]).to.equal('/users/10');
+        expect(config.ajax.putJSON.calledOnce);
+        expect(config.ajax.putJSON.firstCall.args[0]).to.equal('/users/10');
       })
   });
 
-
-  it('generates thunk for `update` operation that dispatches all the actions', function () {
+  it('generates thunk for `delete` operation that dispatches all the actions', function () {
     const options = {
-      operation: 'update',
+      operation: 'del',
       actions: createMockActions(),
       url: '/users/:id'
     };
@@ -92,33 +91,33 @@ describe('generateThunk', function () {
         expect(options.actions.success.calledOnce).to.equal(true);
         expect(dispatch.calledTwice).to.equal(true);
 
-        expect(config.ajax.putJSON.calledOnce);
-        expect(config.ajax.putJSON.firstCall.args[0]).to.equal('/users/10');
+        expect(config.ajax.delJSON.calledOnce);
+        expect(config.ajax.delJSON.firstCall.args[0]).to.equal('/users/10');
       })
   });
 
-  it('generates thunk for `delete` operation that dispatches all the actions', function () {
+  it('generates thunk for `list` operation that dispatches all the actions', function () {
     const options = {
-      operation: 'del',
+      operation: 'list',
       actions: createMockActions(),
-      url: '/users/:id'
+      url: '/users'
     };
     const config = {ajax: createMockAjax()};
     const dispatch = sinon.spy();
-    const thunk = generateThunk(options, config)({params: {id: '10'}});
+    const thunk = generateThunk(options, config)({query: {sort_by: 'age'}});
 
     return thunk(dispatch)
       .then(() => {
         expect(options.actions.wait.calledOnce).to.equal(true);
         expect(options.actions.success.calledOnce).to.equal(true);
         expect(dispatch.calledTwice).to.equal(true);
 
-        expect(config.ajax.delJSON.calledOnce);
-        expect(config.ajax.delJSON.firstCall.args[0]).to.equal('/users/10');
-      })
+        expect(config.ajax.getJSON.calledOnce);
+        expect(config.ajax.getJSON.firstCall.args[0]).to.equal('/users?sort_by=age');
+      });
   });
 
-  it('generates thunk for `list` operation that dispatches all the actions', function () {
+  it('invokes custom onSuccess', function () {
     const options = {
       operation: 'list',
       actions: createMockActions(),
@@ -138,4 +137,28 @@ describe('generateThunk', function () {
         expect(config.ajax.getJSON.firstCall.args[0]).to.equal('/users?sort_by=age');
       });
   });
+
+  it('generates thunk for `read` operation that dispatches all the actions', function () {
+    const options = {
+      operation: 'read',
+      actions: createMockActions(),
+      url: '/users/:id',
+      onSuccess: sinon.spy()
+    };
+    const request = {params: {id: '10'}};
+    const config = {ajax: createMockAjax()};
+    const dispatch = sinon.spy();
+    const thunk = generateThunk(options, config)(request);
+
+    return thunk(dispatch)
+      .then(() => {
+        expect(options.onSuccess.calledOnce);
+
+        const args = options.onSuccess.firstCall.args;
+
+        expect(args[0]).to.have.all.keys('actions', 'dispatch', 'onError', 'done');
+        expect(args[1]).to.equal(request);
+        expect(args[2]).to.equal('getJSON');
+      })
+  });
 });

webpack.config.js

@@ -27,4 +27,4 @@ module.exports = {
       'process.env.NODE_ENV': JSON.stringify(NODE_ENV)
     })
   ]
-};
+};