Fix notification reappearing when service was stopped #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nt4f04uNd
force-pushed
the
notification-reappear
branch
2 times, most recently
from
c374764 to
d090ee4
Compare
nt4f04uNd
force-pushed
the
notification-reappear
branch
from
d090ee4 to
5f63e3f
Compare
ryanheise
reviewed
Oct 1, 2021
| @@ -286,6 +286,7 @@ public int onStartCommand(final Intent intent, int flags, int startId) { | |||
| } | |||
|
|
|||
| public void stop() { | |||
| notificationCreated = false; | |||
There was a problem hiding this comment.
Just wondering whether it would be best to consider androidResumeOnClick here, which is currently used to pass in the argument to stopForeground.
There was a problem hiding this comment.
There was a problem hiding this comment.
Can you point out the expected behavior of androidResumeOnClick that you want it to have, since it's not documented and makes it hard for me to actually judge what's needed here.
|
Marking as draft, because it's better to address #638 first |
|
Closing because this doesn't make much sense as is and we have an ongoing discussion regarding notification in #847 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #690