Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for fits.gz files #90

Merged
merged 5 commits into from
Jul 24, 2024
Merged

Added support for fits.gz files #90

merged 5 commits into from
Jul 24, 2024

Conversation

TheSkyentist
Copy link
Contributor

Solution to #88. No longer any use of splittext for checking file extensions, but rather endswith since .fits.gz has two periods.

@ryanhausen
Copy link
Owner

@TheSkyentist Thanks for the PR!

Have you tried the PR branch on a fits.gz file? Just checking.

Thanks again!

@TheSkyentist
Copy link
Contributor Author

I've tested this on a mix of .fits and .fits.gz files and it works great! I've also now added a pytest for loading a .fits.gz file.

@ryanhausen
Copy link
Owner

@TheSkyentist, thanks for adding a test! LGTM!

@ryanhausen ryanhausen merged commit 3734941 into ryanhausen:master Jul 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants