Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adress get_cmap Deprecation #87

Merged
merged 3 commits into from
Jun 27, 2024
Merged

Adress get_cmap Deprecation #87

merged 3 commits into from
Jun 27, 2024

Conversation

TheSkyentist
Copy link
Contributor

Fixes deprecation of cm.get_cmap since matplotlib 3.7. This will no longer work in latest versions of matplotlib and should maintain compatibility with older versions.

Fixes deprecation of get_cmap since matplotlib 3.7. This will no longer work in latest versions of matplotlib.
@ryanhausen ryanhausen self-assigned this Jun 26, 2024
@ryanhausen
Copy link
Owner

@TheSkyentist Thanks!

It looks like there are some CI issues.

The lint is odd because it's a file you didn't change, so I think that perhaps the formatter I use has made some changes since I last ran the CI. Would you mind running the black formatter and then committing the changes?

The OSX build issue I will take care of.

Then the CI will pass and I can merge. Thanks again!

@TheSkyentist
Copy link
Contributor Author

Done!

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.46%. Comparing base (a7e2119) to head (23bb5fb).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
- Coverage   90.73%   90.46%   -0.27%     
==========================================
  Files           5        5              
  Lines         745      745              
==========================================
- Hits          676      674       -2     
- Misses         69       71       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ryanhausen
Copy link
Owner

Had to move osx-latest to python 3.8, will override python 3.7 action as it will never pass

@ryanhausen ryanhausen merged commit c5b1138 into ryanhausen:master Jun 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants