Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Bootstrap and Bootswatch to v3.4.1, jQuery to v1.12.4 #198

Merged
merged 2 commits into from
Sep 25, 2019

Conversation

vedranmiletic
Copy link
Contributor

Solar theme is unfortunately removed as it was never officially released with
v3.4.1 and instead came out only with Bootswatch v3.3.7 and v4.x.

Fixes issue #190.

@vedranmiletic vedranmiletic changed the title Upgrade Bootstrap and Bootswatch to v3.4.1 (#190) Upgrade Bootstrap and Bootswatch to v3.4.1, jQuery to v1.12.4 Sep 19, 2019
==========
UNRELEASED
==========
* Upgrade Bootstrap and Bootswatch to v3.4.1. (`@vedranmiletic`_)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding history -- form looks great! Your username needs to be defined blow at the bottom of the file like the others as build hits this issue:

WARNING: Unknown target name: "@vedranmiletic".

Copy link
Owner

@ryan-roemer ryan-roemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this work! I tried a couple different bootwatch themes and they're looking good!

You need on small fix in HISTORY.rst and then I'll merge and release!

@vedranmiletic
Copy link
Contributor Author

You need on small fix in HISTORY.rst and then I'll merge and release!

Hopefully fixed.

Solar theme is unfortunately removed as it was never officially released with
v3.4.1 and instead came out only with Bootswatch v3.3.7 and v4.x.
@vedranmiletic
Copy link
Contributor Author

Removed previously accidentally added bootstrap.js.bak file.

Copy link
Owner

@ryan-roemer ryan-roemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great!

@ryan-roemer ryan-roemer merged commit 15ed025 into ryan-roemer:master Sep 25, 2019
@ryan-roemer
Copy link
Owner

Release is delayed as my old fabfile.py release logic has finally bitten the dust as I need twine and installing that doesn't work with old fabric so far... I'll figure it out hopefully soon...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants