Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to bootstrap 3.4 #190

Open
htgoebel opened this issue Jan 20, 2019 · 5 comments
Open

Update to bootstrap 3.4 #190

htgoebel opened this issue Jan 20, 2019 · 5 comments
Labels
feature help wanted

Comments

@htgoebel
Copy link

Please update to bootstrap 3.4, which was release 2018-12-31 and fixed some issues.
@ryan-roemer
Copy link
Owner

Cool! Would love a PR from the community on this one. We've got instructions for updating bootstrap in this project right here to help too: https://github.com/ryan-roemer/sphinx-bootstrap-theme/blob/master/TODO.rst#updating-bootstrap

@vedranmiletic
Copy link
Contributor

@ryan-roemer I have this done locally, I'll pack it and provide a PR.

@htgoebel
Copy link
Author

@vedranmiletic Great!

@htgoebel
Copy link
Author

May it's worth using 3.4.1, which fixes some vulnerabilities: https://blog.getbootstrap.com/2019/02/13/bootstrap-4-3-1-and-3-4-1/

vedranmiletic added a commit to vedranmiletic/sphinx-bootstrap-theme that referenced this issue Sep 19, 2019
@vedranmiletic
Upgrade Bootstrap and Bootswatch to v3.4.1 (ryan-roemer#190)
9d0414f 
Solar theme is unfortunately removed as it was never officially released with
v3.4.1 and instead came out only with Bootswatch v3.3.7 and v4.x.
@vedranmiletic vedranmiletic mentioned this issue Sep 19, 2019
Merged
vedranmiletic added a commit to vedranmiletic/sphinx-bootstrap-theme that referenced this issue Sep 19, 2019
@vedranmiletic
Upgrade Bootstrap and Bootswatch to v3.4.1 (ryan-roemer#190)
0c97491 
Solar theme is unfortunately removed as it was never officially released with
v3.4.1 and instead came out only with Bootswatch v3.3.7 and v4.x.
vedranmiletic added a commit to vedranmiletic/sphinx-bootstrap-theme that referenced this issue Sep 19, 2019
@vedranmiletic
Upgrade Bootstrap and Bootswatch to v3.4.1 (ryan-roemer#190)
1d4c6ad 
Solar theme is unfortunately removed as it was never officially released with
v3.4.1 and instead came out only with Bootswatch v3.3.7 and v4.x.
@vedranmiletic
Copy link
Contributor

Deployed here for a quick test, seems to work fine as far as I can see: https://www.svedruziclab.com/

vedranmiletic added a commit to vedranmiletic/sphinx-bootstrap-theme that referenced this issue Sep 20, 2019
@vedranmiletic
Upgrade Bootstrap and Bootswatch to v3.4.1 (ryan-roemer#190)
cab4f0f 
Solar theme is unfortunately removed as it was never officially released with
v3.4.1 and instead came out only with Bootswatch v3.3.7 and v4.x.
vedranmiletic added a commit to vedranmiletic/sphinx-bootstrap-theme that referenced this issue Sep 24, 2019
@vedranmiletic
Upgrade Bootstrap and Bootswatch to v3.4.1 (ryan-roemer#190)
3f1cc1f 
Solar theme is unfortunately removed as it was never officially released with
v3.4.1 and instead came out only with Bootswatch v3.3.7 and v4.x.
ryan-roemer pushed a commit that referenced this issue Sep 25, 2019
@vedranmiletic @ryan-roemer
Upgrade Bootstrap and Bootswatch to v3.4.1, jQuery to v1.12.4 (#198)
15ed025 
* Upgrade Bootstrap and Bootswatch to v3.4.1 (#190)

Solar theme is unfortunately removed as it was never officially released with
v3.4.1 and instead came out only with Bootswatch v3.3.7 and v4.x.

* Upgrade jQuery to v1.12.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vedranmiletic @ryan-roemer @htgoebel