fix(): removed namespacing and instead we use provided folder from fireDependencies the tool resolves now any package not only monorepo packages #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reDependencies the tool resolves now any package not only monorepo packages
Stradivario
force-pushed
the
67-non-matching-folder-names
branch
from
e17cb48
to
2184330
Compare
|
Hello, do you plan releasing a version that includes this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Description
The tool now assumes not only namespaced packages but instead every npm package.
For some reason the specified folder for the dependency was not used but instead dependencies was splitted and we take the directory based on the name of the package. This was not intended bug the initial purpose of this library was to work with every package not only namespaced.
Type of change