Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix worker proc hanging at exception #172

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Fix worker proc hanging at exception #172

merged 1 commit into from
Jan 10, 2024

Commits on Jan 10, 2024

  1. Fix worker proc hanging at exception 

    Not all exceptions in Task.run will lead to logging_thread.stop(),
which is required that the proc does not hang at exit,
because logging_thread was not a daemon thread.

We make it a daemon thread now.
And also, we additionally make extra sure that logging_thread.stop()
is called.
(Although there are maybe still other rare cases where this is not effective,
so the daemon thread property is still important as well.)

Fix #171.
    @albertz
    albertz committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    afb6c0a View commit details
    Browse the repository at this point in the history