Sync serialization refactor #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move Sync serialization to Common - Move MpReflection to Common - Add simple serialization tests - Make Thing sync worker implicit - Update language version to 12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's some new stuff to accommodate the fact that Common code has to be independent of
VerseandRimWorldbut the changes are mostly straightforward.The moved
SyncSerializationprovides hook lists for reading and writing but I don't thing we'll be exposing them through the API as they are quite powerful.Some more details in the commit message.
It's mostly finished but I'm still planning to create a general way of syncing "
WithImpl".