Changed verb syncing to work closer like IThingHolder #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One of the changes I've proposed in rwmt#411, without any API implementation. List of changes: - `VerbOwnerType` enum was removed and replaced by `supportedVerbOwnerTypes` array - The array includes `typeof(Thing)` in stead of `typeof(Pawn)` for increased compatibility - `IVerbOwner` sync worker entry was added - `Verb` sync worker entry was modified to sync the owner as `IVerbOwner` Those changes should result in greater compatibility, as new supported `IVerbOwner` types can now be added to the array and synced using their own sync workers. This should also end up simplifying `Verb` sync worker going forward, as we won't have to expand it anymore in the future - only the array of supported types. Things that I did not include, but we may want to potentially consider: - Add more vanilla types to the list of supported verb owners, which could include: - `HediffComp` (specifically for `HediffComp_VerbGiver`) - however, in vanilla RW they don't have gizmos, but a mod could add a comp that adds one - `Pawn_MeleeVerbs_TerrainSource` - likely will never gizmos, probably will be completely pointless to include - `Pawn_NativeVerbs` - same as above - Automatically including all subtypes of `IVerbOwner` which have an explicit sync worker - Would simplify mod compat, as mods would (likely) never need to modify the list of supported verb owners - Could have potentially unintended consequences?
|
I think |
I've placed `IVerbOwner` sync worker in the `Interfaces` region, which I've placed at the very bottom. This is due to issues with syncing `IVerbOwner` - for example, trying to sync a `Pawn` caused it to be synced as `IVerbOwner`, which caused it to be recursively synced as `IVerbOwner` until the game crashed. Placing it lower fixed the issue.
…ult" This reverts commit 6a96199.
|
I've attempted to sync The issue is trying to sync (for example) a |
|
This should be entirely addressed by b5a01c3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the changes I've proposed in #411, but without any API implementation.
List of changes:
VerbOwnerTypeenum was removed and replaced bysupportedVerbOwnerTypesarraytypeof(Thing)instead oftypeof(Pawn)for increased compatibilityIVerbOwnersync worker entry was addedVerbsync worker entry was modified to sync the owner asIVerbOwnerThose changes should result in greater compatibility, as new supported
IVerbOwnertypes can now be added to the array and synced using their own sync workers.This should also end up simplifying
Verbsync worker going forward, as we won't have to expand it anymore in the future - only the array of supported types.Things that I did not include, but we may want to potentially consider:
HediffComp(specifically due toHediffComp_VerbGiver) - in vanilla RW they don't have gizmos, but a mod could add a custom hediff comp that adds themPawn_MeleeVerbs_TerrainSource- likely will never get gizmos, probably will be completely pointless to includePawn_NativeVerbs- same as aboveIVerbOwnerwhich have a(n explicit) sync worker