Skip to content

Commit

Permalink
Merge pull request BrentOzarULTD#3394 from HenrikStaunPoulsen/dev
Browse files Browse the repository at this point in the history 
improved performance
  • Loading branch information
@BrentOzar
BrentOzar authored Jan 10, 2024
2 parents f2b7a80 + 9a026de commit 136de61
Showing 1 changed file with 173 additions and 40 deletions.
213 changes: 173 additions & 40 deletions sp_BlitzIndex.sql
View file
Original file line number Diff line number Diff line change
Expand Up @@ -253,9 +253,14 @@ IF OBJECT_ID('tempdb..#CheckConstraints') IS NOT NULL

IF OBJECT_ID('tempdb..#FilteredIndexes') IS NOT NULL
DROP TABLE #FilteredIndexes;

IF OBJECT_ID('tempdb..#Ignore_Databases') IS NOT NULL
DROP TABLE #Ignore_Databases

IF OBJECT_ID('tempdb..#dm_db_partition_stats_etc') IS NOT NULL
DROP TABLE #dm_db_partition_stats_etc
IF OBJECT_ID('tempdb..#dm_db_index_operational_stats') IS NOT NULL
DROP TABLE #dm_db_index_operational_stats

RAISERROR (N'Create temp tables.',0,1) WITH NOWAIT;
CREATE TABLE #BlitzIndexResults
Expand Down Expand Up @@ -1065,6 +1070,8 @@ FROM sys.databases
----------------------------------------
BEGIN TRY
BEGIN
DECLARE @d VARCHAR(19) = CONVERT(VARCHAR(19), GETDATE(), 121);
RAISERROR (N'starting at %s',0,1, @d) WITH NOWAIT;

--Validate SQL Server Version

Expand Down Expand Up @@ -1435,47 +1442,79 @@ BEGIN TRY

--NOTE: If you want to use the newer syntax for 2012+, you'll have to change 2147483647 to 11 on line ~819
--This change was made because on a table with lots of paritions, the OUTER APPLY was crazy slow.
SET @dsql = N'SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED;

-- get relevant columns from sys.dm_db_partition_stats, sys.partitions and sys.objects
DROP TABLE if exists #dm_db_partition_stats_etc
create table #dm_db_partition_stats_etc
(
database_id smallint not null
, object_id int not null
, sname sysname NULL
, index_id int
, partition_number int
, partition_id bigint
, row_count bigint
, reserved_MB bigint
, reserved_LOB_MB bigint
, reserved_row_overflow_MB bigint
, lock_escalation_desc nvarchar(60)
, data_compression_desc nvarchar(60)
)

-- get relevant info from sys.dm_db_index_operational_stats
drop TABLE if exists #dm_db_index_operational_stats
create table #dm_db_index_operational_stats
(
database_id smallint not null
, object_id int not null
, index_id int
, partition_number int
, hobt_id bigint
, leaf_insert_count bigint
, leaf_delete_count bigint
, leaf_update_count bigint
, range_scan_count bigint
, singleton_lookup_count bigint
, forwarded_fetch_count bigint
, lob_fetch_in_pages bigint
, lob_fetch_in_bytes bigint
, row_overflow_fetch_in_pages bigint
, row_overflow_fetch_in_bytes bigint
, row_lock_count bigint
, row_lock_wait_count bigint
, row_lock_wait_in_ms bigint
, page_lock_count bigint
, page_lock_wait_count bigint
, page_lock_wait_in_ms bigint
, index_lock_promotion_attempt_count bigint
, index_lock_promotion_count bigint
, page_latch_wait_count bigint
, page_latch_wait_in_ms bigint
, page_io_latch_wait_count bigint
, page_io_latch_wait_in_ms bigint
)

SET @dsql = N'
DECLARE @d VARCHAR(19) = CONVERT(VARCHAR(19), GETDATE(), 121)
RAISERROR (N''start getting data into #dm_db_partition_stats_etc at %s'',0,1, @d) WITH NOWAIT;
SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED;
INSERT INTO #dm_db_partition_stats_etc
(
database_id, object_id, sname, index_id, partition_number, partition_id, row_count, reserved_MB, reserved_LOB_MB, reserved_row_overflow_MB, lock_escalation_desc, data_compression_desc
)
SELECT ' + CAST(@DatabaseID AS NVARCHAR(10)) + N' AS database_id,
ps.object_id,
s.name,
s.name as sname,
ps.index_id,
ps.partition_number,
ps.partition_id,
ps.row_count,
ps.reserved_page_count * 8. / 1024. AS reserved_MB,
ps.lob_reserved_page_count * 8. / 1024. AS reserved_LOB_MB,
ps.row_overflow_reserved_page_count * 8. / 1024. AS reserved_row_overflow_MB,
le.lock_escalation_desc,
' + CASE WHEN @SQLServerProductVersion NOT LIKE '9%' THEN N'par.data_compression_desc ' ELSE N'null as data_compression_desc ' END + N',
SUM(os.leaf_insert_count),
SUM(os.leaf_delete_count),
SUM(os.leaf_update_count),
SUM(os.range_scan_count),
SUM(os.singleton_lookup_count),
SUM(os.forwarded_fetch_count),
SUM(os.lob_fetch_in_pages),
SUM(os.lob_fetch_in_bytes),
SUM(os.row_overflow_fetch_in_pages),
SUM(os.row_overflow_fetch_in_bytes),
SUM(os.row_lock_count),
SUM(os.row_lock_wait_count),
SUM(os.row_lock_wait_in_ms),
SUM(os.page_lock_count),
SUM(os.page_lock_wait_count),
SUM(os.page_lock_wait_in_ms),
SUM(os.index_lock_promotion_attempt_count),
SUM(os.index_lock_promotion_count),
SUM(os.page_latch_wait_count),
SUM(os.page_latch_wait_in_ms),
SUM(os.page_io_latch_wait_count),
SUM(os.page_io_latch_wait_in_ms), ';

/* Get columnstore dictionary size - more info: https://github.com/BrentOzarULTD/SQL-Server-First-Responder-Kit/issues/2585 */
IF EXISTS (SELECT * FROM sys.all_objects WHERE name = 'column_store_dictionaries')
SET @dsql = @dsql + N' COALESCE((SELECT SUM (on_disk_size / 1024.0 / 1024) FROM ' + QUOTENAME(@DatabaseName) + N'.sys.column_store_dictionaries dict WHERE dict.partition_id = ps.partition_id),0) AS reserved_dictionary_MB ';
ELSE
SET @dsql = @dsql + N' 0 AS reserved_dictionary_MB ';

' + CASE WHEN @SQLServerProductVersion NOT LIKE '9%' THEN N'par.data_compression_desc ' ELSE N'null as data_compression_desc ' END + N'
';

SET @dsql = @dsql + N'
FROM ' + QUOTENAME(@DatabaseName) + N'.sys.dm_db_partition_stats AS ps
Expand All @@ -1484,9 +1523,6 @@ BEGIN TRY
AND so.is_ms_shipped = 0 /*Exclude objects shipped by Microsoft*/
AND so.type <> ''TF'' /*Exclude table valued functions*/
JOIN ' + QUOTENAME(@DatabaseName) + N'.sys.schemas AS s ON s.schema_id = so.schema_id
LEFT JOIN ' + QUOTENAME(@DatabaseName) + N'.sys.dm_db_index_operational_stats('
+ CAST(@DatabaseID AS NVARCHAR(10)) + N', NULL, NULL,NULL) AS os ON
ps.object_id=os.object_id and ps.index_id=os.index_id and ps.partition_number=os.partition_number
OUTER APPLY (SELECT st.lock_escalation_desc
FROM ' + QUOTENAME(@DatabaseName) + N'.sys.tables st
WHERE st.object_id = ps.object_id
Expand All @@ -1506,7 +1542,75 @@ BEGIN TRY
le.lock_escalation_desc,
' + CASE WHEN @SQLServerProductVersion NOT LIKE '9%' THEN N'par.data_compression_desc ' ELSE N'null as data_compression_desc ' END + N'
ORDER BY ps.object_id, ps.index_id, ps.partition_number
OPTION ( RECOMPILE );
/*OPTION ( RECOMPILE );*/
OPTION ( RECOMPILE , min_grant_percent = 1);
SET @d = CONVERT(VARCHAR(19), GETDATE(), 121)
RAISERROR (N''start getting data into #dm_db_index_operational_stats at %s.'',0,1, @d) WITH NOWAIT;
insert into #dm_db_index_operational_stats
(
database_id
, object_id
, index_id
, partition_number
, hobt_id
, leaf_insert_count
, leaf_delete_count
, leaf_update_count
, range_scan_count
, singleton_lookup_count
, forwarded_fetch_count
, lob_fetch_in_pages
, lob_fetch_in_bytes
, row_overflow_fetch_in_pages
, row_overflow_fetch_in_bytes
, row_lock_count
, row_lock_wait_count
, row_lock_wait_in_ms
, page_lock_count
, page_lock_wait_count
, page_lock_wait_in_ms
, index_lock_promotion_attempt_count
, index_lock_promotion_count
, page_latch_wait_count
, page_latch_wait_in_ms
, page_io_latch_wait_count
, page_io_latch_wait_in_ms
)
select os.database_id
, os.object_id
, os.index_id
, os.partition_number
, os.hobt_id
, os.leaf_insert_count
, os.leaf_delete_count
, os.leaf_update_count
, os.range_scan_count
, os.singleton_lookup_count
, os.forwarded_fetch_count
, os.lob_fetch_in_pages
, os.lob_fetch_in_bytes
, os.row_overflow_fetch_in_pages
, os.row_overflow_fetch_in_bytes
, os.row_lock_count
, os.row_lock_wait_count
, os.row_lock_wait_in_ms
, os.page_lock_count
, os.page_lock_wait_count
, os.page_lock_wait_in_ms
, os.index_lock_promotion_attempt_count
, os.index_lock_promotion_count
, os.page_latch_wait_count
, os.page_latch_wait_in_ms
, os.page_io_latch_wait_count
, os.page_io_latch_wait_in_ms
from ' + QUOTENAME(@DatabaseName) + N'.sys.dm_db_index_operational_stats('+ CAST(@DatabaseID AS NVARCHAR(10)) +', NULL, NULL,NULL) AS os
OPTION ( RECOMPILE , min_grant_percent = 1);
SET @d = CONVERT(VARCHAR(19), GETDATE(), 121)
RAISERROR (N''finished getting data into #dm_db_index_operational_stats at %s.'',0,1, @d) WITH NOWAIT;
';
END;
ELSE
Expand Down Expand Up @@ -1605,6 +1709,7 @@ BEGIN TRY
PRINT SUBSTRING(@dsql, 32000, 36000);
PRINT SUBSTRING(@dsql, 36000, 40000);
END;
EXEC sp_executesql @dsql;
INSERT #IndexPartitionSanity ( [database_id],
[object_id],
[schema_name],
Expand Down Expand Up @@ -1639,8 +1744,35 @@ BEGIN TRY
page_io_latch_wait_count,
page_io_latch_wait_in_ms,
reserved_dictionary_MB)
EXEC sp_executesql @dsql;

select h.database_id, h.object_id, h.sname, h.index_id, h.partition_number, h.row_count, h.reserved_MB, h.reserved_LOB_MB, h.reserved_row_overflow_MB, h.lock_escalation_desc, h.data_compression_desc,
SUM(os.leaf_insert_count),
SUM(os.leaf_delete_count),
SUM(os.leaf_update_count),
SUM(os.range_scan_count),
SUM(os.singleton_lookup_count),
SUM(os.forwarded_fetch_count),
SUM(os.lob_fetch_in_pages),
SUM(os.lob_fetch_in_bytes),
SUM(os.row_overflow_fetch_in_pages),
SUM(os.row_overflow_fetch_in_bytes),
SUM(os.row_lock_count),
SUM(os.row_lock_wait_count),
SUM(os.row_lock_wait_in_ms),
SUM(os.page_lock_count),
SUM(os.page_lock_wait_count),
SUM(os.page_lock_wait_in_ms),
SUM(os.index_lock_promotion_attempt_count),
SUM(os.index_lock_promotion_count),
SUM(os.page_latch_wait_count),
SUM(os.page_latch_wait_in_ms),
SUM(os.page_io_latch_wait_count),
SUM(os.page_io_latch_wait_in_ms)
,COALESCE((SELECT SUM (dict.on_disk_size / 1024.0 / 1024) FROM sys.column_store_dictionaries dict WHERE dict.partition_id = h.partition_id),0) AS reserved_dictionary_MB
from #dm_db_partition_stats_etc h
left JOIN #dm_db_index_operational_stats as os ON
h.object_id=os.object_id and h.index_id=os.index_id and h.partition_number=os.partition_number
group by h.database_id, h.object_id, h.sname, h.index_id, h.partition_number, h.partition_id, h.row_count, h.reserved_MB, h.reserved_LOB_MB, h.reserved_row_overflow_MB, h.lock_escalation_desc, h.data_compression_desc

END; --End Check For @SkipPartitions = 0


Expand Down Expand Up @@ -6178,7 +6310,8 @@ BEGIN


END; /* End @Mode=3 (index detail)*/

SET @d = CONVERT(VARCHAR(19), GETDATE(), 121);
RAISERROR (N'finishing at %s',0,1, @d) WITH NOWAIT;
END /* End @TableName IS NULL (mode 0/1/2/3/4) */
END TRY

Expand Down

0 comments on commit 136de61

Please sign in to comment.