Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dataTables base code and extras #222

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

jjimenez
Copy link

I started this fork and pull request in order to update dataTables to the latest version. The version currently included in master has a defect in the responsive extra that makes it impossible to select text within the expander for the rows. This pull request fixes that issue.

@kinsbrunner
Copy link

kinsbrunner commented Jan 15, 2017

Hi,
I have tried using your version of Datatables but, I am getting an error: "File to import not found or unreadable: dataTables/bootstrap/4/jquery.dataTables.bootstrap."
This happens as on my application scss I have the followingg code:

@import "bootstrap-sprockets";
@import "bootstrap";
@import "dataTables/bootstrap/3/jquery.dataTables.bootstrap";

Is there any advice you could give me to solve this?
Thanks and regards.
Alejandro.

@jjimenez
Copy link
Author

@kinsbrunner did you use the install generator? you shouldn't have to manually add the imports to your application scss because the install generator, as described on the home page, for bootstrap 3 adds the appropriate requires to your app/assets/stylesheets/application.css file.

@kinsbrunner
Copy link

kinsbrunner commented Jan 16, 2017 via email

@jjimenez
Copy link
Author

@kinsbrunner I'm not sure this pull request is the right place for this conversation. Please take it to issues or to stack overflow. I'd be happy to participate in the conversation there.

@kinsbrunner
Copy link

Unfortunatelly, no one is answering to threads on original gem... that's why I though you may help me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants