Enable building with libsodium only #49
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… if libsodium reports that aes gcm is not available at runtime, we need to include the necessary files for the reference implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We tried to use noise-c only with libsodium support but without openssl support. For us this didn't work, most likely because if openssl is not used libsodium might still need report at runtime that AES GCM support is not available (probably due to build flags of libsodium) so noise-c falls back to the reference implementation (and rightly so). But in the build configuration this was nit reflected as the static library archive was missing the object files for the reference AES GCM implementation.
This PR includes these files and seems to work well.