Fix possible leaks in examples/echo #48
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In both `echo_load_private_key` and `echo_load_public_key`, when
`len > MAX_DH_KEY_LEN`, the opened file is not closed before the
function returns.
Fix this possible resource leak by opening the file after checking `len`.
This bug was found using clang's static analyzer:
scan-build -enable-checker alpha.unix.Stream make
If either `priv_key` or `pub_key` is `NULL` but not the other one, the allocated memory is not freed. This issue is reported by clang's static analyzer. Fix this by calling `noise_free` in the error block.
niooss-ledger
force-pushed
the
fix-leaks-in-example
branch
from
e59847c
to
6cde834
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
While trying to use
noise-cin some projects based on the given examples, I found some issues which happen in rare error conditions. It would be useful if the issues were fixed in the examples, so that projects which are inspired by them start on a good basis. This is why I am opening this Pull Request.Please see the descriptions of each commit for more information about the fixed issues.
Anyway, thanks for this awesome project!