Fix PSK in rev32 #36
Open
Fix PSK in rev32 #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to §9.2, when `psk` appears in a pattern, the e operation changes from `MixHash(e.public_key)` to `MixHash(e.public_key), MixKey(e.public_key)` This commit makes that change, causing the cacophony vectors to pass.
According to §5.2, in MixKey and MixKeyAndHash, temp_k should be truncated to 32 bytes if HASHLEN is 64.
rweather
reviewed
Apr 24, 2019
| @@ -281,6 +281,10 @@ int noise_symmetricstate_mix_key | |||
| (state->hash, state->ck, hash_len, input, size, | |||
| state->ck, hash_len, temp_k, key_len); | |||
|
|
|||
| /* Truncate temp_k */ | |||
| if (hash_len == 64 && key_len > 32) | |||
There was a problem hiding this comment.
This would seem to prevent the use of symmetric ciphers with more than 256 bits. While the noise specification may have that restriction, I tried to avoid putting that restriction into the code to support future ciphers with larger keys. Why is this needed?
|
Ah, got it. I added it because it was in the spec; if the omission is intentional, I have no problem with skipping. |
bcspragu
added a commit
to bcspragu/noise-c
that referenced
this pull request
Jul 20, 2023
It isn't called that, which I think has something to do with rweather#36, but preshared keys do appear to work correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses Issue #28.