Proposed change for issue #71 #74
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Boundary check for fixed width truncation; skip truncation if text length is smaller than the requested truncation size.
Messed up the last commit
| bite = utils.eatStr(str, side, bite_size, fill); | ||
|
|
||
|
This looks like a dupe of #73 |
|
Yes, both are my accounts and basically the same pullrequests. However I removed the fork from the other account (PR #73) and made PR from this one. (I didn't find any way to cancel the pull request, I'm fairly new to github, so it lingers there) The whitespace, however, is from the original file and not directly related to my changes, even though github shows this as a diff. Are You sure You want it removed ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Boundary check for fixed width truncation; skip truncation if text length is smaller than the requested truncation size.